Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPhone 14 Pro and Pro Max screenshots have a new screen size that is not supported by deliver #20653

Open
4 tasks done
chrisvasselli opened this issue Sep 14, 2022 · 9 comments

Comments

@chrisvasselli
Copy link

chrisvasselli commented Sep 14, 2022

New Issue Checklist

Issue Description

It looks like support for the new iPhone 14 Pro and Pro Max screenshot size needs to be added to deliver. The new screenshot size specifications can be found here: https://help.apple.com/app-store-connect/#/devd274dd925

Command executed

bundle exec fastlane deliver --skip_binary_upload --skip_metadata --force --overwrite_screenshots --api_key_path

Complete output when running fastlane, including the stack trace and command used
[09:52:08]: Successfully loaded '/Users/biggs/jenkins/workspace/Upload App Store Screenshots/StudyJapanese/Deliverfile' 📄

+----------------------------+-------------------------------+
| Detected Values from './Deliverfile' |
+----------------------------+-------------------------------+
| metadata_path | AppStoreConnect/metadata |
| screenshots_path | AppStoreConnect/screenshots |
| app_identifier | com.serpentisei.studyjapanese |
| username | |
| team_name | Serpenti Sei LLC |
| run_precheck_before_submit | false |
+----------------------------+-------------------------------+

[09:52:08]: Creating authorization token for App Store Connect API

+--------------------------------------+----------------------------------+
| deliver 2.209.1 Summary |
+--------------------------------------+----------------------------------+
| skip_binary_upload | true |
| skip_metadata | true |
| force | true |
| overwrite_screenshots | true |
| api_key_path | |
| username | |
| app_identifier | com.serpentisei.studyjapanese |
| platform | ios |
| edit_live | false |
| use_live_version | false |
| metadata_path | AppStoreConnect/metadata |
| screenshots_path | AppStoreConnect/screenshots |
| skip_screenshots | false |
| skip_app_version_update | false |
| sync_screenshots | false |
| submit_for_review | false |
| verify_only | false |
| reject_if_possible | false |
| phased_release | false |
| reset_ratings | false |
| team_name | Serpenti Sei LLC |
| run_precheck_before_submit | false |
| precheck_default_rule_level | warn |
| ignore_language_directory_validation | false |
| precheck_include_in_app_purchases | true |
+--------------------------------------+----------------------------------+

[09:52:11]: 🚫 Invalid screenshots were detected! Here are the reasons:
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/de-DE/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/de-DE/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/de-DE/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/de-DE/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/de-DE/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/de-DE/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/en-US/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/en-US/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/en-US/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/en-US/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/en-US/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/en-US/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/es-MX/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/es-MX/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/es-MX/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/es-MX/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/es-MX/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/es-MX/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/fr-FR/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/fr-FR/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/fr-FR/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/fr-FR/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/fr-FR/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/fr-FR/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/nl-NL/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/nl-NL/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/nl-NL/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/nl-NL/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/nl-NL/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/nl-NL/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/ru/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/ru/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/ru/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/ru/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/ru/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/ru/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hans/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hans/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hans/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hans/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hans/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hans/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hant/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hant/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hant/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hant/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hant/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hant/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)

[!] Canceled uploading screenshots. Please check the error messages above and fix the screenshots.

Environment

✅ fastlane environment ✅

Stack

Key Value
OS 12.5.1
Ruby 3.0.1
Bundler? true
Git git version 2.37.0 (Apple Git-136)
Installation Source ~/jenkins/workspace/Fastlane Env/StudyJapanese/vendor/bundle/ruby/3.0.0/bin/fastlane
Host macOS 12.5.1 (21G83)
Ruby Lib Dir ~/.rbenv/versions/3.0.1/lib
OpenSSL Version OpenSSL 1.1.1j 16 Feb 2021
Is contained false
Is homebrew false
Is installed via Fabric.app false
Xcode Path /Applications/Xcode.app/Contents/Developer/
Xcode Version 14.0
Swift Version 5.7

System Locale

Variable Value
LANG en_US.UTF-8
LC_ALL en_US.UTF-8
LANGUAGE

fastlane files:

No Fastfile found

No Appfile found

fastlane gems

Gem Version Update-Status
fastlane 2.209.1 ✅ Up-To-Date
trainer 0.9.1 ✅ Up-To-Date

Loaded fastlane plugins:

No plugins Loaded

Loaded gems
Gem Version
did_you_mean 1.5.0
bundler 2.2.15
tsort 0.1.0
uri 0.10.1
pathname 0.1.0
rake 13.0.6
rexml 3.2.5
CFPropertyList 3.0.5
concurrent-ruby 1.1.10
i18n 1.12.0
minitest 5.16.2
tzinfo 2.0.5
zeitwerk 2.6.0
activesupport 6.1.6.1
public_suffix 4.0.7
addressable 2.8.1
httpclient 2.8.3
json 2.6.2
algoliasearch 1.27.5
artifactory 3.0.15
atomos 0.1.3
aws-eventstream 1.2.0
aws-partitions 1.629.0
aws-sigv4 1.5.1
jmespath 1.6.1
aws-sdk-core 3.146.0
aws-sdk-kms 1.58.0
aws-sdk-s3 1.114.0
babosa 1.0.4
claide 1.1.0
fuzzy_match 2.0.4
nap 1.1.0
netrc 0.11.0
ffi 1.15.5
ethon 0.15.0
typhoeus 1.4.0
cocoapods-core 1.11.3
cocoapods-deintegrate 1.0.5
cocoapods-downloader 1.6.3
cocoapods-plugins 1.0.0
cocoapods-search 1.0.1
cocoapods-trunk 1.6.0
cocoapods-try 1.2.0
colored2 3.1.2
escape 0.0.4
fourflusher 2.3.1
gh_inspector 1.1.3
molinillo 0.8.0
ruby-macho 2.5.1
nanaimo 0.3.0
xcodeproj 1.22.0
cocoapods 1.11.3
colored 1.2
highline 2.0.3
commander 4.6.0
declarative 0.0.20
digest-crc 0.6.4
unf_ext 0.0.8.2
unf 0.1.4
domain_name 0.5.20190701
dotenv 2.8.1
emoji_regex 3.2.3
excon 0.92.4
faraday-em_http 1.0.0
faraday-em_synchrony 1.0.0
faraday-excon 1.1.0
faraday-httpclient 1.0.1
multipart-post 2.0.0
faraday-multipart 1.0.4
faraday-net_http 1.0.1
faraday-net_http_persistent 1.2.0
faraday-patron 1.0.0
faraday-rack 1.0.0
faraday-retry 1.0.3
ruby2_keywords 0.0.5
faraday 1.10.2
http-cookie 1.0.5
faraday-cookie_jar 0.0.7
faraday_middleware 1.2.0
fastimage 2.2.6
jwt 2.5.0
memoist 0.16.2
multi_json 1.15.0
os 1.1.4
signet 0.17.0
googleauth 1.2.0
mini_mime 1.1.2
trailblazer-option 0.1.2
uber 0.1.0
representable 3.2.0
retriable 3.1.2
webrick 1.7.0
google-apis-core 0.7.0
google-apis-androidpublisher_v3 0.26.0
google-apis-playcustomapp_v1 0.10.0
google-apis-iamcredentials_v1 0.13.0
google-apis-storage_v1 0.17.0
google-cloud-env 1.6.0
google-cloud-errors 1.3.0
google-cloud-core 1.6.0
google-cloud-storage 1.39.0
mini_magick 4.11.0
naturally 2.2.1
optparse 0.1.1
plist 3.6.0
rubyzip 2.3.2
security 0.1.3
simctl 1.6.8
terminal-notifier 2.0.0
unicode-display_width 1.8.0
terminal-table 1.8.0
tty-screen 0.8.1
tty-cursor 0.7.1
tty-spinner 0.9.3
word_wrap 1.0.0
rouge 2.0.7
xcpretty 0.3.0
xcpretty-travis-formatter 1.0.1

generated on: 2022-09-14

@NilsBerni
Copy link

Got the same issue for 1290 × 2796. Is there a solution to it?

@chrisvasselli
Copy link
Author

Looks like Deliver needs to be updated to support the new size. Unfortunately I haven't had time to dive in and try to make a PR myself. Looks like it would involve updating app_screenshot.rb with the new sizes, and finding other places where those sizes are referenced and updating the necessary places with the new sizes.

Also will need to figure out how to handle the fact that there's already a 6.1-inch size in Deliver listed for the iPhone XR, which is a different screen size than what Apple is now calling the 6.1-inch screenshot size (for iPhone 14 Pro)

@cherpake
Copy link
Contributor

Same problem here :(

@cherpake
Copy link
Contributor

I hacked something together here to upload 6.7 inch screenshots
https://github.com/cherpake/fastlane

@diniska
Copy link

diniska commented Oct 16, 2022

Experiencing the same issue with the message:

[21:27:03]: 🚫 Error: ./fastlane/screenshots/sk/iPhone 14 Pro Max-1_searchWithImages_framed.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)

The link there specifies 1290x2796 as a valid screen size.

@guidev
Copy link
Contributor

guidev commented Nov 1, 2022

fixed in #20777

@marcpalmer
Copy link

Is there a chance of this being resolved soon? The fix in #20777 doesn't look like it supports 14 Pro Max, only Pro.

@fastlane-bot
Copy link

The pull request #20694 that closed this issue was merged and released as part of fastlane 2.211.0 🚀
Please let us know if the functionality works as expected as a reply here. If it does not, please open a new issue. Thanks!

@chrisvasselli
Copy link
Author

I just tested this, and it does seem to be working for iPhone 14 Pro Max screenshots!

It looks like #20777 will add support for iPhone 14 Pro, so this issue is not completely resolved until that fix is merged as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants