Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frameit] "fastlane frameit" doesn't detect iPhone 13 Pro #20514

Closed
4 tasks done
guidev opened this issue Jul 28, 2022 · 4 comments · Fixed by #20642
Closed
4 tasks done

[frameit] "fastlane frameit" doesn't detect iPhone 13 Pro #20514

guidev opened this issue Jul 28, 2022 · 4 comments · Fixed by #20642

Comments

@guidev
Copy link
Contributor

guidev commented Jul 28, 2022

New Issue Checklist

Issue Description

I'm trying to frame a iPhone 13 Pro screenshot taken from the simulator.

Unfortunately it looks like that frameit uses the iPhone 13 frame instead of the Pro.

Am I missing something?

Command executed

fastlane frameit

Complete output when running fastlane, including the stack trace and command used
 
fastlane frameit --verbose
[✔] 🚀
[00:04:07]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
INFO [2022-07-29 00:04:08.05]: Using device frames version 'latest'
[⠋] Framing screenshot './Simulator Screen Shot - iPhone 13 Pro - 2022-07-28 at 23.58.03.png' DEBUG [2022-07-29 00:04:08.08]: Looking for Apple iPhone 13 Midnight and found 1 template(s)
[✔] Framing screenshot './Simulator Screen Shot - iPhone 13 Pro - 2022-07-28 at 23.58.03.png'
INFO [2022-07-29 00:04:14.59]: Added frame: '/Users/redacted/Simulator Screen Shot - iPhone 13 Pro - 2022-07-28 at 23.58.03_framed.png'
 

Environment

 
✅ fastlane environment ✅

Stack

Key Value
OS 12.5
Ruby 3.1.2
Bundler? false
Git git version 2.37.1
Installation Source /usr/local/lib/ruby/gems/3.1.0/bin/fastlane
Host macOS 12.5 (21G72)
Ruby Lib Dir /usr/local/Cellar/ruby/3.1.2/lib
OpenSSL Version OpenSSL 1.1.1n 15 Mar 2022
Is contained false
Is homebrew false
Is installed via Fabric.app false
Xcode Path /Applications/Xcode.app/Contents/Developer/
Xcode Version 13.4.1
Swift Version 5.6.1

System Locale

Variable Value
LANG en_US.UTF-8
LC_ALL en_US.UTF-8
LANGUAGE

fastlane files:

No Fastfile found

No Appfile found

fastlane gems

Gem Version Update-Status
fastlane 2.208.0 ✅ Up-To-Date

Loaded fastlane plugins:

No plugins Loaded

Loaded gems
Gem Version
error_highlight 0.3.0
did_you_mean 1.6.1
rouge 2.0.7
xcpretty 0.3.0
terminal-notifier 2.0.0
terminal-table 1.8.0
plist 3.6.0
addressable 2.8.0
multipart-post 2.0.0
word_wrap 1.0.0
optparse 0.1.1
tty-screen 0.8.1
tty-cursor 0.7.1
tty-spinner 0.9.3
artifactory 3.0.15
babosa 1.0.4
colored 1.2
highline 2.0.3
commander 4.6.0
faraday-cookie_jar 0.0.7
faraday_middleware 1.2.0
fastimage 2.2.6
gh_inspector 1.1.3
mini_magick 4.11.0
naturally 2.2.1
rubyzip 2.3.2
security 0.1.3
xcpretty-travis-formatter 1.0.1
simctl 1.6.8
jwt 2.4.1
uber 0.1.0
declarative 0.0.20
trailblazer-option 0.1.2
representable 3.2.0
retriable 3.1.2
mini_mime 1.1.2
memoist 0.16.2
multi_json 1.15.0
os 1.1.4
signet 0.17.0
googleauth 1.2.0
httpclient 2.8.3
rexml 3.2.5
webrick 1.7.0
google-apis-core 0.7.0
google-apis-playcustomapp_v1 0.10.0
google-apis-androidpublisher_v3 0.25.0
google-cloud-env 1.6.0
google-cloud-errors 1.2.0
google-cloud-core 1.6.0
google-apis-iamcredentials_v1 0.13.0
google-apis-storage_v1 0.18.0
digest-crc 0.6.4
google-cloud-storage 1.37.0
emoji_regex 3.2.3
aws-sdk-kms 1.58.0
aws-sdk-s3 1.114.0
set 1.0.2
nanaimo 0.3.0
colored2 3.1.2
claide 1.1.0
CFPropertyList 3.0.5
atomos 0.1.3
xcodeproj 1.22.0
unicode-display_width 1.8.0
public_suffix 4.0.7
excon 0.92.4
ruby2_keywords 0.0.5
faraday-retry 1.0.3
faraday-rack 1.0.0
faraday-patron 1.0.0
faraday-net_http_persistent 1.2.0
faraday-net_http 1.0.1
faraday-multipart 1.0.4
faraday-httpclient 1.0.1
faraday-excon 1.1.0
faraday-em_synchrony 1.0.0
faraday-em_http 1.0.0
faraday 1.10.0
unf_ext 0.0.8.2
unf 0.1.4
domain_name 0.5.20190701
http-cookie 1.0.5
json 2.6.2
dotenv 2.8.1
bundler 2.3.19
rake 13.0.6
aws-eventstream 1.2.0
aws-sigv4 1.5.1
aws-partitions 1.611.0
jmespath 1.6.1
aws-sdk-core 3.131.4
forwardable 1.3.2
logger 1.5.1
pathname 0.2.0
shellwords 0.1.0
cgi 0.3.2
date 3.2.2
timeout 0.3.0
stringio 3.0.2
securerandom 0.2.0
uri 0.11.0
openssl 3.0.0
digest 3.1.0
io-nonblock 0.1.0
ipaddr 1.2.4
io-wait 0.2.3
zlib 2.1.1
resolv 0.2.1
time 0.2.0
open-uri 0.2.0
mutex_m 0.1.1
net-http 0.2.2
net-protocol 0.1.3
connection_pool 2.2.5
net-http-persistent 4.0.1
patron 0.13.3
ostruct 0.5.5
english 0.7.1
erb 2.2.3
strscan 3.0.4
abbrev 0.1.0
io-console 0.5.11
tempfile 0.1.2
delegate 0.2.0
fileutils 1.6.0
tmpdir 0.1.2
base64 0.1.1
singleton 0.1.1
open3 0.1.1
nkf 0.1.1
prettyprint 0.1.1
pp 0.3.0
find 0.1.1
yaml 0.2.0
psych 4.0.4
ox 2.13.2

generated on: 2022-07-29

Screenshot

Simulator Screen Shot - iPhone 13 Pro - 2022-07-28 at 23 58 03

Framed Screenshot

Simulator Screen Shot - iPhone 13 Pro - 2022-07-28 at 23 58 03_framed

@Fuller05767
Copy link

Fuller05767 commented Aug 4, 2022

I faced similar kind of issue last time, I am still searching for some proper solution. Fortiva Credit Card

@fastlane-bot
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with fastlane and feel free to tackle this issue yourself 💪

This issue will be auto-closed if there is no reply within 1 month.

@guidev
Copy link
Contributor Author

guidev commented Sep 10, 2022

this is still an issue with fastlane 2.209.1

@fastlane-bot
Copy link

The pull request #20642 that closed this issue was merged and released as part of fastlane 2.211.0 🚀
Please let us know if the functionality works as expected as a reply here. If it does not, please open a new issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants