Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snapshot] Fix Swift compiler version check for SnapshotHelper.swift #18930

Merged

Conversation

minuscorp
Copy link
Collaborator

@minuscorp minuscorp commented Jun 20, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Closes #18792

Description

There was a wrong compiler version check for UIImagePNGRepresentation deprecation, which led to a compile error in snapshot

Testing Steps

  1. Checkout this branch.
  2. Go to snapshot and open the Example.xcodeproj
  3. Open SnapshotHelper.swift with a Swift version set at 4.0
  4. Compile it.
  5. 馃殌

@google-cla google-cla bot added the cla: yes label Jun 20, 2021
@minuscorp minuscorp linked an issue Jun 20, 2021 that may be closed by this pull request
4 tasks
@google-cla
Copy link

google-cla bot commented Jun 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

鈩癸笍 Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jun 23, 2021
@joshdholtz
Copy link
Member

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 23, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! 鉂わ笍

@joshdholtz joshdholtz merged commit 414591b into fastlane:master Jun 23, 2021
Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 馃帀 This was released as part of fastlane 2.186.0 馃殌

@fastlane fastlane locked and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[snapshot] SnapshotHelper.swift has Swift Compiler Error
3 participants