Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fastlane_core] Fix the ensure_array_type_passes_validation error message #18927

Merged
merged 1 commit into from Jun 23, 2021
Merged

[fastlane_core] Fix the ensure_array_type_passes_validation error message #18927

merged 1 commit into from Jun 23, 2021

Conversation

crazymanish
Copy link
Member

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

  • Fix the ensure_array_type_passes_validation error message
  • Added unit tests

Testing Steps

  • No functionality changed, all existing/new unit tests should pass.

@google-cla google-cla bot added the cla: yes label Jun 20, 2021
@fastlane fastlane deleted a comment from Thomasmark5 Jun 21, 2021
joshdholtz
joshdholtz approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG I’m the worst 😭 Thank you!

@joshdholtz joshdholtz merged commit 286aa9b into master Jun 23, 2021
@joshdholtz joshdholtz deleted the crazymanish-ensure_array_type_passes_validation-clean-up branch June 23, 2021 00:53
@joshdholtz joshdholtz mentioned this pull request Jun 23, 2021
Merged
fastlane-bot
fastlane-bot reviewed Jun 23, 2021
View reviewed changes
Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.186.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fastlane-bot fastlane-bot fastlane-bot left review comments

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crazymanish @joshdholtz @fastlane-bot