Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[match] add git authentication methods to match import command #18903

Conversation

rb1193
Copy link
Contributor

@rb1193 rb1193 commented Jun 18, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Unfortunately two tests are failing for reasons I don't understand - possibly fastlane is caching the auth credentials somewhere?

Failed examples:
rspec ./fastlane/spec/actions_specs/import_from_git_spec.rb:162 # Fastlane Fastlane::FastFile import_from_git with caching works with new tags
rspec ./fastlane/spec/actions_specs/import_from_git_spec.rb:200 # Fastlane Fastlane::FastFile import_from_git with caching works with branch

Motivation and Context

Similar to #18202 but for fastlane match import. I've been attempting to upload new certs, keys and provisioning profiles using basic authorization but that's not possible because the git_basic_authorization parameter is not available when using match import

Description

Added the git_private_key, git_basic_authorization and git_bearer_authorization parameters to the match import storage client

Testing Steps

Use fastlane match import with the --git-basic-authorization parameter set

@google-cla
Copy link

google-cla bot commented Jun 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 18, 2021
@rb1193
Copy link
Contributor Author

rb1193 commented Jun 20, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 20, 2021
@joshdholtz joshdholtz changed the title Add git authentication methods to match import command [match] add git authentication methods to match import command Jun 23, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, can’t believe this was forgotten 😱 Thank you for adding this! Really appreciate it ❤️

@joshdholtz joshdholtz merged commit 5b62b3c into fastlane:master Jun 23, 2021
Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.186.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants