[action][git_commit] remove all instances of is_string in options and use type
#18883
Conversation
| @@ -71,7 +67,7 @@ def self.is_supported?(platform) | |||
|
|
|||
| def self.example_code | |||
| [ | |||
| 'git_commit(path: "./version.txt", message: "Version Bump")', | |||
| # 'git_commit(path: "./version.txt", message: "Version Bump")', | |||
There was a problem hiding this comment.
Force to disable this otherwise test_sample_code is failing...same as last PR: #18882 (comment)
waiting for Josh's recommendation here 😇
There was a problem hiding this comment.
There was a problem hiding this comment.
@crazymanish What did you run to get this error? 🤔 I checked out this branch and wasn't getting this 😛
There was a problem hiding this comment.
Step1: Uncomment below example code (remove #)
# 'git_commit(path: "./version.txt", message: "Version Bump")',
Step2: Run bundle exec fastlane validate_docs
There was a problem hiding this comment.
Oh, duh! You commented them out 😛
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
@crazymanish Added a fix for |
Thank you, thank you! 🚀 |
|
|
||
| # Arrays can be an either be an array or string that gets split by comma in auto_convert_type | ||
| if !value.kind_of?(Array) && !value.kind_of?(String) | ||
| UI.user_error!("'#{self.key}' value must be either `true` or `false`! Found #{value.class} instead.") |
There was a problem hiding this comment.
| UI.user_error!("'#{self.key}' value must be either `true` or `false`! Found #{value.class} instead.") | |
| UI.user_error!("'#{self.key}' value must be either `array` or `comma seperated string`! Found #{value.class} instead.") |
|
Hey @crazymanish 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
is_stringis slowly being replaced bytypeto make the docs clearer, options safer, and Swift generation more correct.git_commitaction.Description
is_string: truefrom optionsTesting Steps
bundle exec rspec fastlane/spec/actions_specs/git_commit_spec.rb