[action][git_add] remove all instances of is_string in options and use type
#18882
Conversation
| # 'git_add(path: "./Frameworks/*", shell_escape: false)', | ||
| 'git_add(path: ["*.h", "*.m"], shell_escape: false)' | ||
| # 'git_add(path: "./Frameworks/*", shell_escape: false)', | ||
| # 'git_add(path: "*.txt", shell_escape: false)' |
There was a problem hiding this comment.
Force to disable this otherwise test_sample_code is failing...
https://github.com/fastlane/fastlane/blob/master/fastlane/actions/test_sample_code.rb
Not sure, how to deal with it properly, will wait for Josh's recommendation here 😇
There was a problem hiding this comment.
|
@crazymanish I'll handle this rebase! |
joshdholtz
force-pushed
the
crazymanish-git_add-clean-up
branch
from
c579a4a
to
ed7f7b5
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
Hey @crazymanish 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
is_stringis slowly being replaced bytypeto make the docs clearer, options safer, and Swift generation more correct.git_addaction.Description
is_string: truefrom optionsTesting Steps
bundle exec rspec fastlane/spec/actions_specs/git_add_spec.rb