Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[match] fix nuke exception when nuking with the empty files storage #18864

Merged
merged 1 commit into from Jun 23, 2021

Conversation

crazymanish
Copy link
Member

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

  • Now, initializing files_to_delete with [] if needed.
    Please note: I notice there is no spec file for this nuke.rb 🀯 I will be adding all the unit-tests for all the FastlaneTools once I will finish Fastlane actions' is_string deprecation goal!

Testing Steps

  • I don't know exactly... πŸ€·β€β™‚οΈ
  • maybe create a new certificate manually? and don't store that in git-repo and run nuke 😜🀨

@google-cla google-cla bot added the cla: yes label Jun 12, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Thank you for fixing 😊

@joshdholtz joshdholtz merged commit eb602f8 into master Jun 23, 2021
@joshdholtz joshdholtz deleted the crazymanish-match-nuke-empty-storage-fix branch June 23, 2021 02:26
Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! πŸŽ‰ This was released as part of fastlane 2.186.0 πŸš€

@fastlane fastlane locked and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined method `count' for nil:NilClass in nuke
3 participants