[regression][pilot] Fix upload using api_key_path + apple_id CLI options

[crazymanish]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

• Resolves [Regression] fastlane pilot upload is failing when --apple_id (-p) is provided  #18767
• Pilot upload is still failing when using api_key_path + apple_id CLI options
• Please see this: [regression][pilot] Fix upload using api_key_path + apple_id input options #18771 (comment)

Description

• Pilot will do login on start if spaceship token is nil and input options have api_key_path

Testing Steps

• Added the unit-tests for this new functionality 😇

• Update Gemfile and run bundle install with

gem "fastlane", :git => "git@github.com:fastlane/fastlane.git", :branch => "crazymanish-pilot-upload-using-cli-with-api-key-fix"

• Try pilot's upload using CLI with api_key_path and apple_id

bundle exec fastlane pilot upload --api_key_path /Users/runner/work/_temp/api_key***.json -p 1528xxxxxx`

[joshdholtz]

Hear me out here... maybe the should_login argument on start() should only apply to Apple ID login 🤔

The reason that exists is because of avoiding 2FA stuff that was super annoying on CI and whatnot. So maybe we revert this change in BuildManager and instead...

1. Login in start if there is a token
2. If no token and should_login, then we attempt to login with Apple ID

I think that is essentially what this is doing but we should maybe move that to the start / login methods 🤷‍♂️

[crazymanish]

maybe the should_login argument on start() should only apply to Apple ID login 🤔

Yes, this is it. this should be the case! You are 💯 right 💪

• Login in start if there is a token
• If no token and should_login, then we attempt to login with Apple ID

Okay, I think, i require your help in this PR...don't want to break our lovely pilot 😇 Do you want to take over, or shall I try first? 🙇

[joshdholtz]

@crazymanish Ha! You can start if you'd like and then I can add a commit if I see anything that needs to change 🤷‍♂️ Otherwise I don't mind taking over from here! Your call 😊

[joshdholtz]

One small thought otherwise this looks good!

[joshdholtz]

I really like this solution! 😊 Thanks for reworking this ❤️

[fastlane-bot]

Hey @crazymanish 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.186.0 🚀