New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action]Adds action for obtaining remote repo default branch #18845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I totes see a need for this. Just got two small requests 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, one minor suggestion if you agree! 🚀
@joshdholtz Can you please check on your change request? |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you so much for adding that remote_name
option 🙌 I added one commit to clean up some syntax but other than that this is 💯 Really appreciate this ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.186.0 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
This introduces a new action to obtain the default branch name from a remote git repository. Doing this can support other actions such as creating merge requests by ensuring that the proper branch name is provided as a target. With the shift away from "master", it is beneficial to have this kind of flexibility.
Description
A new action has been created in the source control category that enables retrieving a remote git repository's default branch.
It was tested under the following conditions:
Testing Steps
bundle exec fastlane run git_default_remote_branch
bundle exec fastlane run git_default_remote_branch
bundle exec fastlane run git_default_remote_branch
. Default name should be seenbundle exec fastlane run git_default_remote_branch
. Default name should be seen