Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deliver][spaceship] migrate AgeRatingDeclaration from AppStoreVersion to AppInfo for App Store Connect API 1.3 update #18732

Merged
merged 7 commits into from
May 22, 2021
Merged

[deliver][spaceship] migrate AgeRatingDeclaration from AppStoreVersion to AppInfo for App Store Connect API 1.3 update #18732

merged 7 commits into from
May 22, 2021

Conversation

joshdholtz
Copy link
Member

Motivation and Context

App Store Connect API released version 1.3 today

  • AgeRatingDelcaration deprecated on AppStoreVersion
  • AgeRatingDeclaration added as relationship on AppInfo
  • gamblingAndContests split into
    • gambling (boolean value)
    • contests (string value)
  • Added new seventeenPlus rating (boolean value)

Description

  • Moved API and helper methods from AppStoreVersion to AppInfo
  • Added a new deprecation method on AgeRatingDelcaration to map values to new format if possible
    • Returns the changed Hash
    • Returns deprecation messages to be printed out
    • Returns error messages to be raised

[deliver][spaceship] migrate AgeRatingDeclaration from AppStoreVersio…
480a8fa 
…n to AppInfo for App Store Connect API 1.3 update
@google-cla google-cla bot added the cla: yes label May 21, 2021
ainame
ainame requested changes May 21, 2021
View reviewed changes
Copy link
Contributor

@ainame ainame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so quick! Amazing to see you've done this update from day 1😍
Changes make sense to me. What I suggested is mostly improving minor details.

spaceship/lib/spaceship/connect_api/models/age_rating_declaration.rb Outdated Show resolved Hide resolved
deliver/lib/deliver/upload_metadata.rb Outdated Show resolved Hide resolved
spaceship/lib/spaceship/connect_api/tunes/tunes.rb Outdated Show resolved Hide resolved
Josh Holtz and others added 3 commits May 21, 2021 18:10
@ainame
Update deliver/lib/deliver/upload_metadata.rb
f57aa01 
Co-authored-by: Satoshi Namai <s.namai.09@gmail.com>
@ainame
Update spaceship/lib/spaceship/connect_api/tunes/tunes.rb
0dbba82 
Co-authored-by: Satoshi Namai <s.namai.09@gmail.com>
PR improvements
ecd93bd
@joshdholtz joshdholtz requested a review from ainame May 21, 2021 23:33
ainame
ainame approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@ainame ainame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joshdholtz joshdholtz merged commit 90062c9 into master May 22, 2021
@joshdholtz joshdholtz deleted the joshdholtz-asc-api-1.3-age-rating-updates branch May 22, 2021 00:05
@joshdholtz joshdholtz mentioned this pull request May 22, 2021
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.184.0 🚀

@Saravia83c
Copy link

@

@fastlane fastlane locked and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ainame ainame ainame approved these changes

@rogerluan rogerluan Awaiting requested review from rogerluan

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joshdholtz @fastlane-bot @Saravia83c @ainame