Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resign] fix incorrectly typoed variable name #18715

Merged
merged 1 commit into from
May 19, 2021

Conversation

silvervest
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

As @kapfab found in #18713 (comment), a previous variable name was incorrectly set when fixing a merge conflict. This resolves that.

Description

Changing the variable from $CERTIFICATE to the local $certificate_name to ensure the correct environment is used when processing iCloud Environment keys

Testing Steps

@google-cla google-cla bot added the cla: yes label May 19, 2021
@silvervest silvervest changed the title fix incorrectly typoed variable name [resign] fix incorrectly typoed variable name May 19, 2021
@silvervest
Copy link
Contributor Author

@joshdholtz apologies to bug you, this is a fix for an error in my PR you merged earlier today that could affect some distribution resigning. It would be good to merge at the same time to avoid issues! Thanks again!

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up so quickly on this! 😊

@joshdholtz joshdholtz merged commit 17f9bdf into fastlane:master May 19, 2021
@fastlane-bot
Copy link

Hey @silvervest 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.184.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants