[supply][Ruby 3] fix Ruby 3 keyword args issues #18703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ainame
commented
May 17, 2021
| @@ -279,13 +279,13 @@ def latest_version(track) | |||
| def update_listing_for_language(language: nil, title: nil, short_description: nil, full_description: nil, video: nil) | |||
| ensure_active_edit! | |||
|
|
|||
| listing = AndroidPublisher::Listing.new(**{ | |||
There was a problem hiding this comment.
Since other places already use keyword-ish style arguments, I made this consistent with others. ** would make sense where Hash object is given from somewhere else whereas this is just a hash literal that we can just omit {}.
[1] pry(main)> def hello(**args)
[1] pry(main)* p args
[1] pry(main)* end
=> :hello
[2] pry(main)> hello(a: 1, b: 2)
{:a=>1, :b=>2}
=> {:a=>1, :b=>2}
[3] pry(main)> hello(**{a: 1, b: 2})
{:a=>1, :b=>2}
=> {:a=>1, :b=>2}
[4] pry(main)> hello({a: 1, b: 2})
ArgumentError: wrong number of arguments (given 1, expected 0)
from (pry):1:in `hello'
Both result in the same
There was a problem hiding this comment.
ainame
commented
May 17, 2021
| @@ -233,10 +233,10 @@ def upload_changelog(language, version_code) | |||
| end | |||
| end | |||
|
|
|||
| AndroidPublisher::LocalizedText.new({ | |||
| AndroidPublisher::LocalizedText.new( | |||
joshdholtz
changed the title
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.183.2 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
#18698
Description
Due to the lack of unit tests, we missed some Ruby 3 keyword args issues. I fixed another issue in
supply/lib/supply/uploader.rb.I checked with
git grep "Google::Apis"andgit grep "AndroidPublisher::"but the rest looks okay.Testing Steps