Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fastlane_core][configuration] suggestion message improvement when fetching value with non-symbol key #18696

Merged

Conversation

crazymanish
Copy link
Member

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

  • When fetching value with non-symbol key Fastlane provides us the suggestion to use symbol key, which was slightly outdated and was using :app_id in the example always.

Description

  • Fix the suggestion message, now Fastlane will provide us symbol key suggestion always instead of hardcoded :app_id

Testing Steps

  • Updated unit tests
  • Nothing changed in functionality

@google-cla google-cla bot added the cla: yes label May 16, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can’t believe it was every doing this 😛 Thank you for improving this! Really appreciate it ❤️

@joshdholtz joshdholtz merged commit dbb983f into fastlane:master May 19, 2021
@crazymanish crazymanish deleted the fastlane-core-config-fetch-improvement branch May 19, 2021 08:59
@fastlane-bot
Copy link

Hey @crazymanish 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.184.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants