-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action][swiftlint] Added support for --fix mode
option
#18695
[action][swiftlint] Added support for --fix mode
option
#18695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor addition but this is very legit! Thank you for the contribution!
Looks great, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Really love the version checking 😍 Just a few small nit picks otherwise 💯
Thank you for your review, applied suggestions! 😇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is 🔥 Thank you so much for all the work on this one ❤️ Really appreciate it!
Hey @crazymanish 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.184.0 🚀 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
autocorrect
mode and introduced--fix
mode (Please see attached screenshot)Description (In this PR)
--fix
modeTesting Steps
bundle exec fastlane test
or
bundle install
withScreenshot
.
.