[fastlane_core] fix parsing of passwords with trailing spaces due to wrong whitespace handling in Fastlane::Shell::password method

[bliednov]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

Resolves #18683

Description

The default highline whitespace handling is :strip that simply removes all trailing whitespaces (see the related docs). I changed it to :chomp.

I assume that trailing tabs and spaces should be permitted for passwords.

Testing Steps

The following passwords would fail previously:

• "password_with_a_space_in_the_end "
• "password_with_multiple_spaces_in_the_end "
• "password_with_multiple_spaces_and_tabs_in_the_end \t \t"

In order to test it you can create a keychain with the following command and use one of the passwords from above:

$ security create-keychain ~/Library/Keychains/test.keychain-db

Next, you should use one of the actions that will try to use that keychain:

1. E.g. by specifying MATCH_KEYCHAIN_NAME=test and running match.
2. Or e.g. with bundle exec fastlane run get_certificates keychain_path:~/Library/Keychains/test.keychain-db

[joshdholtz]

This makes sense to me! I don't think this should cause any breaking changes 🤷‍♂️ Really appreciate the contribution ❤️

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.183.0 🚀