[Fastlane.Swift] Fix `OptionalConfigValue` for `Any`-based types. #18664

minuscorp · 2021-05-09T13:26:59Z

Checklist

I've run bundle exec rspec from the root directory to see all new and existing tests pass
I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
I've read the Contribution Guidelines
I've updated the documentation if necessary.

Motivation and Context

OptionalConfigValue does not provide an ExpressibleBy interface for Any? parameters, so they have to be filtered out afterwards.
Fixes #18654

Description

OptionalConfigItem does not apply to Any types to avoid a breaking compatibility against past releases. This PR resolves the issue.

Testing Steps

Install the following branch:

gem 'fastlane', :branch => 'https://github.com/minuscorp/fastlane/fix-configvalue-with-any-type'

Use an action with an Any value:

incrementBuildNumber(buildNumber: <#T##Any?#>)

Check that the value is being passed when it is not nil.
🚀

ainame

Had a minor suggestion to make it simpler but LGTM

ainame · 2021-05-10T21:41:47Z

fastlane/lib/fastlane/swift_fastlane_function.rb

@@ -325,7 +326,7 @@ def implementation
        implm += "let args: [RubyCommand.Argument] = []\n"
      else
        implm += "let args = [#{args.group_by { |h| h[:name] }.keys.join(",\n")}]\n"
-        implm += ".compactMap { $0 }\n"
+        implm += ".compactMap { $0?.nilify(when: { $0.value == nil }) }\n"


Suggested change

implm += ".compactMap { $0?.nilify(when: { $0.value == nil }) }\n"

implm += ".filter { $0?.value != nil }\n"

What about this? Isn't this simpler?

🤦‍♂️ I'm an idiot

Wasn't exactly doing that, but gave me the idea to get rid of the nilify method ❤️

joshdholtz

I tried doing incrementBuildNumber(buildNumber: 5) but I got 👇

value of protocol type 'Any' cannot conform to 'ExpressibleByIntegerLiteral'; only struct/enum/class types can conform to protocols

Am I doing something wrong? 😇

minuscorp · 2021-05-14T04:58:36Z

But it works fine with you for float and string values?🤔

EDIT: I fixed it I think (tested as much as I could)

RyuX51 · 2021-05-14T13:12:02Z

I tried the fix-configvalue-with-any-types branch and I'm getting

▸ Compiling Fastfile.swift

❌  .../Fastfile.swift:22:21: cannot convert value of type 'String' to expected argument type 'OptionalConfigValue<String?>'

      echo(message: "Unknown parameter value \(bumpType)")
                    ^


** BUILD FAILED **

for the following code:

  func betaLane(withOptions options: [String: String]?) {

    let bumpType = options?["bumpType"] ?? "patch"

    if !["major", "minor", "patch"].contains(bumpType) {
      echo(message: "Unknown parameter value \(bumpType)")
      return
    }

If I do without string interpolation it works fine. Thanks.

Since I'm coming from 18654, I'll just drop this here.

minuscorp · 2021-05-14T18:54:59Z

@RyuX51 could you check that your issue is solved now?

RyuX51 · 2021-05-14T19:39:47Z

@minuscorp I'm sorry, c1b9cf1still behaves the same.

minuscorp · 2021-05-14T20:00:38Z

bumpType is String or String??

RyuX51 · 2021-05-14T20:11:46Z

It's String, but this isn't the problem. For example

echo(message: "Unknown " + "parameter")

and

echo(message: "Unknown \("parameter")")

also lead to the same error whereas

echo(message: "Unknown parameter")

is just fine.

minuscorp · 2021-05-14T20:21:28Z

I just tested using

let string = "Foo"

echo(message: "Message \(string)")

Working🤔

RyuX51 · 2021-05-14T20:34:01Z

@minuscorp

Using fastlane 2.182.0 from https://github.com/minuscorp/fastlane (at fix-configvalue-with-any-types@c1b9cf1)

So this should be the right commit, right?

▸ Compiling Fastfile.swift

❌  /Users/mario/Repository/VJeton/fastlane/Fastfile.swift:24:12: missing argument label 'message:' in call

      echo("Message \(string)")
           ^



❌  /Users/mario/Repository/VJeton/fastlane/Fastfile.swift:24:12: cannot convert value of type 'String' to expected argument type 'OptionalConfigValue<String?>'

      echo("Message \(string)")
           ^


** BUILD FAILED **

And when I add the message: it's again:

▸ Compiling Fastfile.swift

❌  /Users/mario/Repository/VJeton/fastlane/Fastfile.swift:24:21: cannot convert value of type 'String' to expected argument type 'OptionalConfigValue<String?>'

      echo(message: "Message \(string)")
                    ^


** BUILD FAILED **

minuscorp · 2021-05-14T20:40:50Z

Pretty confusing to me 😔

Whereas

Does fail because there isn't interface in Swift for that kind of Expressible afaik

RyuX51 · 2021-05-14T20:49:30Z

@minuscorp Even echo(message: String("Message")) fails for me. 🤷‍♂️

minuscorp · 2021-05-14T20:51:30Z

I'd reset the repo and try to run the generate_swift_api lane before going further, maybe something in the project it's corrupted😞

minuscorp · 2021-05-15T12:01:34Z

@joshdholtz Can you replicate the issue or it is working fine for you?🤔

minuscorp · 2021-05-18T06:42:30Z

Any news @RyuX51 regarding the issue with interpolation?

RyuX51 · 2021-05-18T10:18:42Z

@minuscorp Well, I haven't investigated further. I just set up a new project where I wanted to try a Fastlane.swift for the first time. The fact that I get this error while wanting to show a value in an informational output is not really a blocker for me. This problem just sounded a lot like what you are fixing here is related, and I just wanted to let you know. Since you can't even replicate the bug, I don't want to bother you with it any longer.

joshdholtz · 2021-05-19T09:26:44Z

@minuscorp I’m still getting…

value of protocol type 'Any' cannot conform to 'ExpressibleByUnicodeScalarLiteral'; only struct/enum/class types can conform to protocols

when my Fastlane.swift file looks like…

incrementBuildNumber(buildNumber: "5")

Are you not getting that same thing? 🤔

minuscorp · 2021-05-19T09:43:59Z

@joshdholtz indeed, I removed all conformances to Optional, as it seems to not accept Any meta value, differently from AnyObject which it could conform to those extensions. Fixed and tested:

incrementBuildNumber(buildNumber: 1.0, xcodeproj: "asd")
incrementBuildNumber(buildNumber: "1.0")
incrementBuildNumber(buildNumber: 1)

joshdholtz

This works for me! ❤️ LGTM

Merge whenever you are ready

fastlane-bot · 2021-05-19T19:31:40Z

Hey @minuscorp 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

fastlane-bot · 2021-05-24T19:30:41Z

Congratulations! 🎉 This was released as part of fastlane 2.184.0 🚀

[Fastlane.Swift] Fix OptionalConfigValue for Any-based types.

8df47bb

minuscorp added the topic: swift label May 9, 2021

minuscorp requested review from joshdholtz, ainame and rogerluan May 9, 2021 13:26

minuscorp self-assigned this May 9, 2021

google-cla bot added the cla: yes label May 9, 2021

ainame approved these changes May 10, 2021

View reviewed changes

Review comments

fc123d0

joshdholtz requested changes May 13, 2021

View reviewed changes

Fix for Any? with ExpressibleByIntegerLiteral

188b00d

minuscorp requested a review from joshdholtz May 14, 2021 10:03

Added support for String interpolation

c1b9cf1

Fix for optional meta values

8fee843

joshdholtz approved these changes May 19, 2021

View reviewed changes

minuscorp merged commit e1b6a6a into fastlane:master May 19, 2021

fastlane-bot added the status: included-in-next-release label May 19, 2021

joshdholtz mentioned this pull request May 22, 2021

Version bump to 2.184.0 #18733

Merged

fastlane-bot removed the status: included-in-next-release label May 24, 2021

fastlane-bot added the status: released label May 24, 2021

fastlane-bot mentioned this pull request May 24, 2021

[Fastlane.Swift] cannot convert value of type 'String' to expected argument type 'OptionalConfigValue<Any?>' #18654

Closed

4 tasks

fastlane locked and limited conversation to collaborators Jul 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fastlane.Swift] Fix `OptionalConfigValue` for `Any`-based types. #18664

[Fastlane.Swift] Fix `OptionalConfigValue` for `Any`-based types. #18664

minuscorp commented May 9, 2021

ainame left a comment

ainame May 10, 2021 •

edited

minuscorp May 11, 2021

minuscorp May 11, 2021

joshdholtz left a comment

minuscorp commented May 14, 2021 •

edited

RyuX51 commented May 14, 2021 •

edited

minuscorp commented May 14, 2021

RyuX51 commented May 14, 2021

minuscorp commented May 14, 2021

RyuX51 commented May 14, 2021

minuscorp commented May 14, 2021 •

edited

RyuX51 commented May 14, 2021

minuscorp commented May 14, 2021 •

edited

RyuX51 commented May 14, 2021

minuscorp commented May 14, 2021

minuscorp commented May 15, 2021

minuscorp commented May 18, 2021

RyuX51 commented May 18, 2021 •

edited

joshdholtz commented May 19, 2021

minuscorp commented May 19, 2021

joshdholtz left a comment

fastlane-bot commented May 19, 2021

fastlane-bot commented May 24, 2021

	implm += ".compactMap { $0?.nilify(when: { $0.value == nil }) }\n"
	implm += ".filter { $0?.value != nil }\n"

[Fastlane.Swift] Fix OptionalConfigValue for Any-based types. #18664

[Fastlane.Swift] Fix OptionalConfigValue for Any-based types. #18664

Conversation

minuscorp commented May 9, 2021

Checklist

Motivation and Context

Description

Testing Steps

ainame left a comment

Choose a reason for hiding this comment

ainame May 10, 2021 • edited

Choose a reason for hiding this comment

minuscorp May 11, 2021

Choose a reason for hiding this comment

minuscorp May 11, 2021

Choose a reason for hiding this comment

joshdholtz left a comment

Choose a reason for hiding this comment

minuscorp commented May 14, 2021 • edited

RyuX51 commented May 14, 2021 • edited

minuscorp commented May 14, 2021

RyuX51 commented May 14, 2021

minuscorp commented May 14, 2021

RyuX51 commented May 14, 2021

minuscorp commented May 14, 2021 • edited

RyuX51 commented May 14, 2021

minuscorp commented May 14, 2021 • edited

RyuX51 commented May 14, 2021

minuscorp commented May 14, 2021

minuscorp commented May 15, 2021

minuscorp commented May 18, 2021

RyuX51 commented May 18, 2021 • edited

joshdholtz commented May 19, 2021

minuscorp commented May 19, 2021

joshdholtz left a comment

Choose a reason for hiding this comment

fastlane-bot commented May 19, 2021

fastlane-bot commented May 24, 2021

[Fastlane.Swift] Fix `OptionalConfigValue` for `Any`-based types. #18664

[Fastlane.Swift] Fix `OptionalConfigValue` for `Any`-based types. #18664

ainame May 10, 2021 •

edited

minuscorp commented May 14, 2021 •

edited

RyuX51 commented May 14, 2021 •

edited

minuscorp commented May 14, 2021 •

edited

minuscorp commented May 14, 2021 •

edited

RyuX51 commented May 18, 2021 •

edited