Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[action][git_pull] clean-up the verify-blocks for Boolean validation #18662

Merged
merged 1 commit into from
May 13, 2021
Merged

[action][git_pull] clean-up the verify-blocks for Boolean validation #18662

merged 1 commit into from
May 13, 2021

Conversation

crazymanish
Copy link
Member

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

  • git_pull action verify_blocks was using old fashion style Bool validation

Description

  • Now added, type: Boolean which will do Bool validation itself, without adding extra verify_block

Testing Steps

  • No functionality changed really, just a small clean-up.

@google-cla google-cla bot added the cla: yes label May 8, 2021
joshdholtz
joshdholtz approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is beautiful! Thanks you for yet another contribution ❤️❤️❤️

@joshdholtz joshdholtz merged commit a1c4729 into fastlane:master May 13, 2021
@crazymanish crazymanish deleted the git-pull-clean-up branch May 14, 2021 04:47
@joshdholtz joshdholtz mentioned this pull request May 14, 2021
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.183.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crazymanish @fastlane-bot @joshdholtz