Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scan] fix regular expression to find failed tests suite-name #18661

Merged
merged 3 commits into from
May 13, 2021

Conversation

crazymanish
Copy link
Member

@crazymanish crazymanish commented May 8, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

  • Earlier, Regular expression was failing to find tests suite-name when the project scheme was having "non-whitespace" character i.e dash -
  • Now, Updated the regular expression to find tests suite-name even if a project scheme will have "non-whitespace" character i.e dash -

Testing Steps

  • Added Unit test for "non-whitespace" character scheme which should pass
    or
  • Unzip demo project scan-broken-dashtests.zip
  • Update/Install bundle using bundle install or bundle update
  • Run bundle exec fastlane test

Screenshot

Screenshot 2021-05-08 at 20 19 53

Copy link
Collaborator

@minuscorp minuscorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! Really appreciate it ❤️

@joshdholtz joshdholtz merged commit 0b2d94b into fastlane:master May 13, 2021
@crazymanish crazymanish deleted the scan-suite-name-regex-fix branch May 14, 2021 04:48
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.183.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[scan] Schemes with dashes in the name can't retry tests
4 participants