Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pilot] Introducing timeout feature for Apple build-processing waiting-time #18660

Merged
merged 6 commits into from
May 19, 2021

Conversation

crazymanish
Copy link
Member

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Apple build processing does not work very well always... Randomly CI keeps running for Apple build processing waiting time until CI timeout itself i.e CircleCI has 5 Hours timeout

Problem:

  • Running CI for one job 5 hours randomly create waiting-queue for other jobs
  • Manually we have to stop the CI job after a certain time...i.e 1 hour [This is slightly inconvenience 😇]

Description

  • Introducing timeout feature for Apple build-processing waiting-time
  • FastlaneCore::BuildWatcher will 'force stop' watching build after timeout duration
  • Please see attached screenshot for logs

Testing Steps

  • Update Gemfile and run bundle install with
gem "fastlane", :git => "git@github.com:crazymanish/fastlane.git", :branch => "pilot-timeout"
  • With the below test lane, run bundle exec fastlane test
lane :test do
    PILOT_WAIT_PROCESSING_TIMEOUT_DURATION=60 # in your .env file

    gym
    pilot
  end
lane :test do
    gym
    pilot(wait_processing_timeout_duration: 60)
  end

Screenshot

Screenshot 2021-05-08 at 17 52 12

@google-cla google-cla bot added the cla: yes label May 8, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really cool change! I think this makes a lot of sense to add 😊 Would you be able to add some tests again this? Let me know if you need any help or have any questions on this 💪

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the tests!! One more small suggestion 😊

fastlane_core/lib/fastlane_core/build_watcher.rb Outdated Show resolved Hide resolved
@google-cla
Copy link

google-cla bot commented May 19, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels May 19, 2021
@joshdholtz
Copy link
Member

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels May 19, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good! Thank you so much for adding this feature 😊 This is going to be great 🥳 ❤️

@joshdholtz joshdholtz merged commit 8cc5b15 into fastlane:master May 19, 2021
@crazymanish crazymanish deleted the pilot-timeout branch May 20, 2021 06:53
@fastlane-bot
Copy link

Hey @crazymanish 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.184.0 🚀

@hilsenrat
Copy link

Thanks @crazymanish! This new flag is really useful.

@fastlane fastlane locked and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants