-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pilot] Introducing timeout feature
for Apple build-processing waiting-time
#18660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really cool change! I think this makes a lot of sense to add 😊 Would you be able to add some tests again this? Let me know if you need any help or have any questions on this 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the tests!! One more small suggestion 😊
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all good! Thank you so much for adding this feature 😊 This is going to be great 🥳 ❤️
Hey @crazymanish 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.184.0 🚀 |
Thanks @crazymanish! This new flag is really useful. |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Apple build processing does not work very well always... Randomly CI keeps running for Apple build processing waiting time until CI timeout itself i.e CircleCI has 5 Hours timeout
Problem:
Description
timeout feature
for Apple build-processing waiting-timeFastlaneCore::BuildWatcher
will 'force stop' watching build after timeout durationTesting Steps
bundle install
withbundle exec fastlane test
Screenshot