-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action][danger] Add fail-if-no-pr flag to Danger action #18657
[action][danger] Add fail-if-no-pr flag to Danger action #18657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃
FastlaneCore::ConfigItem.new(key: :fail_if_no_pr, | ||
env_name: "FL_DANGER_FAIL_IF_NO_PR", | ||
description: "Fail Danger execution if no PR is found", | ||
type: Boolean, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃槈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small change otherwise 馃挴
env_name: "FL_DANGER_FAIL_IF_NO_PR", | ||
description: "Fail Danger execution if no PR is found", | ||
type: Boolean, | ||
optional: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional can be removed if there is a default_value
for a type: Boolean
馃槉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks for adding this 鉂わ笍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 馃帀 This was released as part of fastlane 2.183.0 馃殌
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
This PR adds the missing
fail-if-no-pr
flag of Danger action that was missing from the config.Description
Added the corresponding
ConfigItem
and append it to the command in the Danger call.Testing Steps
fail-if-no-pr
flag is added when configured like so.