-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deliver] remove all instances of is_string
in options and use type
#18617
Conversation
Does |
dc694a3
to
ebe6524
Compare
ebe6524
to
fcbe130
Compare
is_string
in options and use type
Hey @joshdholtz 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.184.0 🚀 |
Motivation and Context
is_string
is slowly being replaced bytype
(andskip_type_validation
if needed) to make the docs clearer, options safter, and Swift generation more correct.This PR does this for only
deliver
Description
is_string
that a adefault_value
of atrue
/false
were replacd withtype: Boolean
Symbol
was addedto_sym
skip_type_validation
was added toteam_id
since it can take strings and numbers:app
is no longer being used as a cache and replaced withDeliver.cache
Spaceship::ConnectAPI::App
)Deliver.cache
where app is stored instead