Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deliver] remove all instances of is_string in options and use type #18617

Merged
merged 6 commits into from
May 19, 2021

Conversation

joshdholtz
Copy link
Member

@joshdholtz joshdholtz commented Apr 28, 2021

Motivation and Context

is_string is slowly being replaced by type (and skip_type_validation if needed) to make the docs clearer, options safter, and Swift generation more correct.

This PR does this for only deliver

Description

  • Most is_string that a a default_value of a true/false were replacd with type: Boolean
  • Support for type Symbol was added
    • Will show string in CLI options
    • String values will get converted with to_sym
  • skip_type_validation was added to team_id since it can take strings and numbers
  • Option :app is no longer being used as a cache and replaced with Deliver.cache
    • This option was never set with anything being passed in (only used as a global cache for Spaceship::ConnectAPI::App)
    • Added new Deliver.cache where app is stored instead

@google-cla google-cla bot added the cla: yes label Apr 28, 2021
@minuscorp
Copy link
Collaborator

Does type-less ConfigItem get declared as String in Swift or into Any?

@joshdholtz joshdholtz force-pushed the joshdholtz-deliver-options-use-bool-type branch from ebe6524 to fcbe130 Compare May 14, 2021 18:37
@joshdholtz joshdholtz changed the title [deliver] remove all instances of is_string and use type [deliver] remove all instances of is_string in options and use type May 19, 2021
@joshdholtz joshdholtz merged commit 56b7fec into master May 19, 2021
@joshdholtz joshdholtz deleted the joshdholtz-deliver-options-use-bool-type branch May 19, 2021 09:58
@fastlane-bot
Copy link

Hey @joshdholtz 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.184.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants