Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snapshot] added iPhone 12 models to snapshot reports generator #18535

Merged
merged 1 commit into from Apr 14, 2021

Conversation

nutsmuggler
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

The snapshot command generates iPhone 12 screenshot correctly, but the screenshot are not inserted in the screenshots.html file.
After some googling I found out a similar issue, #6690.
This issue, now solved, was related to iPhone SE. After inspecting snapshot/lib/snapshot/reports_generator.rb I realized iPhone 12 models were completely missing.

Description

I added the four models of iPhone 12 to the hash returned by xcode_9_and_above_device_name_mappings.

I then tested the feature by adding the four devices to my app snapfile.
Screenshots were generated correctly.
I also did some tests to make the change worked also with a single device, or a couple.

Testing Steps

Test with a project setup for fast lane snapshots.
Modify your Snapfile to include the four iPhone 12 models, like this:

 devices([
    "iPhone 12",
   "iPhone 12 mini",
    "iPhone 12 Pro",
    "iPhone 12 Pro Max"
 ])

Run bundle exec fastlane snapshot
Verify. the four iPhone 12 models are added to the snapshot.html file.

@google-cla
Copy link

google-cla bot commented Apr 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Apr 9, 2021
Copy link
Collaborator

@minuscorp minuscorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sign the CLA and it's good to go 🚀

@nutsmuggler
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 10, 2021
@joshdholtz joshdholtz changed the title Added iPhone 12 models to snapshot reports generator [snapshot] added iPhone 12 models to snapshot reports generator Apr 14, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I actually didn’t know snapshot had this mapping 🤦 I will remember this for the future! Thank you for fixing ❤️

@joshdholtz joshdholtz merged commit bc4a564 into fastlane:master Apr 14, 2021
@nutsmuggler
Copy link
Contributor Author

nutsmuggler commented Apr 14, 2021

@joshdholtz thanks! I just thought I'd do it straightaway since it was something simple. Also, an opportunity to learn how to properly do pull request on a public projects. Thank YOU guys for the good work!

@fastlane-bot
Copy link

Hey @nutsmuggler 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.181.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants