[gym] fix in the gym/runner. When moving mac 'app' silently fails if file already exist in that location.

[krzysiek84]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

I've found a bug in the export of the mac app using developer-id. Looks like the app file generated by fastlane did not contain valid entitlements. After investigation, it looks like the exported app is the one from Xcode archive, and not the one from exporter tool.

Description

I've used the following config:

build_mac_app(
    workspace: 'Journal.xcworkspace',
    scheme: 'Diarly_Setapp',
    configuration: 'Release',
    export_options: {
      iCloudContainerEnvironment: 'Production',
      provisioningProfiles: specifiers
    },
    export_method: 'developer-id',
    output_directory: 'build/setapp',
  )

When I verified created App file with:

codesign -d --entitlements :entitlements.plist Diarly.app

I've noticed that the iCloudContainerEnvironment was not set correctly. After applying the fix (removing existing app file) everything worked ok.

What's interesting / off the topic, when I use skip-package option the export options are ignored (not sure if it's expected behavior). Was expecting even the app without package to be exported.

Testing Steps

I've used the following action to verify if the iCloudContainerEnvironment is set after export is done

module Fastlane
  module Actions

    class VerifyIcloudEnvironmentAction < Action
      def self.run(params)
        UI.message "Verifying if the app is set to correct icloud-container-environment"

        entitlements_path = "entitlements.plist"
        sh("codesign -d --entitlements :#{entitlements_path} #{params[:path]}")

        entitlements = File.open(entitlements_path) { |f| Plist.parse_xml(f) }

        value = entitlements['com.apple.developer.icloud-container-environment']
        if value != "Production"
          UI.abort_with_message! "iCloud container was not set to production!"
        end
      end


      def self.description
        "Verifies the app is using correct icloud-container-environment"
      end

      def self.available_options
        [
          FastlaneCore::ConfigItem.new(key: :path,
                                       description: "path to the .app file to verify",
                                       is_string: true),
        ]
      end

      def self.authors
        ["krzysztof"]
      end

      def self.is_supported?(platform)
        true
      end
    end
  end
end

[joshdholtz]

Gaahhh, I can’t believe it wasn’t already doing this 😱 Thank you so much for catching this fix! Really appreciate the contribution ❤️

[fastlane-bot]

Hey @krzysiek84 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.181.0 🚀