Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supply] upload native symbols for crash symbolication #18526

Merged
merged 3 commits into from Apr 19, 2021

Conversation

capyvara
Copy link
Contributor

@capyvara capyvara commented Apr 9, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Fixes #17517, this allows uploading native symbols zip file in order for the Google Play Console to symbolicate crashes.

Google Documentation: https://support.google.com/googleplay/android-developer/answer/9848633#

Description

It's a simple change, at the upload_mapping it looks for the file extensions and decide to use either the parameter "proguard" or "nativeCode" when it's a .zip.

It only can be uploaded together in the same edit as the .apk or .abb upload.

I've tested to upload it alone after and it says "The Deobfuscation File can't be modified", however you can still do it manually via web later, but beware that any crash types that happened before won't be symbolicated.

Testing Steps

  • Generate your project zipped symbols following the format mentioned on Google's documentation.
  • bundler exec fastlane supply -f path/to/yourapp.aab -d path/to/symbols.zip --package_name "yourpackage.name" --skip_upload_metadata --skip_upload_images --skip_upload_screenshots
  • It should print something like Preparing mapping at path... after the app binary upload.
  • You can check later at the Google Play Console if the symbols file are there:
    image

@google-cla google-cla bot added the cla: yes label Apr 9, 2021
@aberaud
Copy link

aberaud commented Apr 9, 2021

Does it allow to upload a proguard and a native debug file in the same upload?

@capyvara
Copy link
Contributor Author

capyvara commented Apr 9, 2021

Does it allow to upload a proguard and a native debug file in the same upload?

Yes, but you need to use --mapping_paths, which accepts an array, instead of just --mapping

@joshdholtz joshdholtz changed the title Supply upload native symbols for crash symbolication [supply] upload native symbols for crash symbolication Apr 19, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for adding support for this 😊

@joshdholtz joshdholtz merged commit e726767 into fastlane:master Apr 19, 2021
@fastlane-bot
Copy link

Hey @capyvara 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.181.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants