[supply] upload native symbols for crash symbolication #18526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Fixes #17517, this allows uploading native symbols zip file in order for the Google Play Console to symbolicate crashes.
Google Documentation: https://support.google.com/googleplay/android-developer/answer/9848633#
Description
It's a simple change, at the upload_mapping it looks for the file extensions and decide to use either the parameter
"proguard"
or"nativeCode"
when it's a.zip
.It only can be uploaded together in the same edit as the
.apk
or.abb
upload.I've tested to upload it alone after and it says
"The Deobfuscation File can't be modified"
, however you can still do it manually via web later, but beware that any crash types that happened before won't be symbolicated.Testing Steps
bundler exec fastlane supply -f path/to/yourapp.aab -d path/to/symbols.zip --package_name "yourpackage.name" --skip_upload_metadata --skip_upload_images --skip_upload_screenshots
Preparing mapping at path...
after the app binary upload.