Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React Native] Hermes on iOS (react-native 0.64) #17657

Closed
4 tasks done
mrousavy opened this issue Nov 23, 2020 · 1 comment
Closed
4 tasks done

[React Native] Hermes on iOS (react-native 0.64) #17657

mrousavy opened this issue Nov 23, 2020 · 1 comment

Comments

@mrousavy
Copy link

New Issue Checklist

Issue Description

React Native 0.64-rc0 was released, which includes opt-in support for the Hermes JS executor (instead of JSC). (see react-native-community/releases#214)

I've upgraded my project to use RN 0.64 rc and enabled hermes which works as expected in debug builds. Unfortunately I couldn't run fastlane beta anymore, since it seems that this requires additional changes from the fastlane CLI.

Command executed
fastlane beta
Complete output when running fastlane, including the stack trace and command used

It looks like only the bundle command fails, since fastlane doesn't expect hermes bitcode instead of the js bundle.

 
▸ Processing Info.plist
▸ Running script 'Bundle React Native code and images'
    the transform cache was reset.

❌ /Users/mrousavy/Library/Developer/Xcode/DerivedData/Springsale-cdueuzbwshyvojabkcrtvdjvltvy/Build/Intermediates.noindex/ArchiveIntermediates/Springsale/BuildProductsPath/Release-iphoneos/main.jsbundle:1:1: Invalid UTF-8 continuation byte

��
�'
^

❌ error: File /Users/mrousavy/Library/Developer/Xcode/DerivedData/Springsale-cdueuzbwshyvojabkcrtvdjvltvy/Build/Intermediates.noindex/ArchiveIntermediates/Springsale/BuildProductsPath/Release-iphoneos/Springsale.app/main.jsbundle does not exist. This must be a bug with

Environment

 
| Key                         | Value                                                          |
| --------------------------- | -------------------------------------------------------------- |
| OS                          | 11.0.1                                                         |
| Ruby                        | 2.6.3                                                          |
| Bundler?                    | false                                                          |
| Git                         | git version 2.24.3 (Apple Git-128)                             |
| Installation Source         | /usr/local/bin/fastlane                                        |
| Host                        | macOS 11.0.1 (20B29)                                           |
| Ruby Lib Dir                | /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib |
| OpenSSL Version             | LibreSSL 2.8.3                                                 |
| Is contained                | false                                                          |
| Is homebrew                 | false                                                          |
| Is installed via Fabric.app | false                                                          |
| Xcode Path                  | /Applications/Xcode.app/Contents/Developer/                    |
| Xcode Version               | 12.2                                                           |

System Locale

Error
No Locale with UTF8 found 🚫

fastlane gems

Gem Version Update-Status
fastlane 2.166.0 🚫 Update available

Loaded fastlane plugins:

No plugins Loaded

Loaded gems

Gem Version
did_you_mean 1.3.0
slack-notifier 2.3.2
rouge 2.0.7
xcpretty 0.3.0
terminal-notifier 2.0.0
unicode-display_width 1.7.0
terminal-table 1.8.0
plist 3.5.0
addressable 2.7.0
multipart-post 2.0.0
word_wrap 1.0.0
tty-screen 0.8.1
tty-cursor 0.7.1
tty-spinner 0.9.3
babosa 1.0.4
colored 1.2
highline 1.7.10
commander-fastlane 4.4.6
unf_ext 0.0.7.7
unf 0.1.4
domain_name 0.5.20190701
http-cookie 1.0.3
faraday-cookie_jar 0.0.7
faraday_middleware 1.0.0
fastimage 2.2.0
gh_inspector 1.1.3
mini_magick 4.10.1
rubyzip 2.3.0
security 0.1.3
xcpretty-travis-formatter 1.0.0
dotenv 2.7.6
bundler 2.1.4
naturally 2.2.0
simctl 1.6.8
jwt 2.2.2
uber 0.1.0
declarative 0.0.20
declarative-option 0.1.0
representable 3.0.4
retriable 3.1.2
mini_mime 1.0.2
multi_json 1.15.0
signet 0.14.0
memoist 0.16.2
os 1.1.1
googleauth 0.14.0
httpclient 2.8.3
google-api-client 0.38.0
google-cloud-errors 1.0.1
google-cloud-core 1.5.0
rake 13.0.1
digest-crc 0.6.1
google-cloud-storage 1.29.1
nanaimo 0.3.0
colored2 3.1.2
claide 1.0.3
CFPropertyList 3.0.2
atomos 0.1.3
xcodeproj 1.19.0
public_suffix 4.0.6
excon 0.78.0
ruby2_keywords 0.0.2
faraday 1.1.0
json 2.3.1
google-cloud-env 1.4.0
emoji_regex 3.2.1
aws-eventstream 1.1.0
aws-sigv4 1.2.2
aws-partitions 1.388.0
jmespath 1.4.0
aws-sdk-core 3.109.1
aws-sdk-kms 1.39.0
aws-sdk-s3 1.83.1
forwardable 1.2.0
logger 1.3.0
stringio 0.0.2
ipaddr 1.2.2
openssl 2.1.2
ostruct 0.1.0
strscan 1.0.0
date 2.0.0
fileutils 1.1.0
etc 1.0.1
io-console 0.4.7
zlib 1.0.0
libxml-ruby 3.1.0
rexml 3.2.4
psych 3.1.0
mutex_m 0.1.0
webrick 1.4.2

generated on: 2020-11-23

@mrousavy
Copy link
Author

Nevermind, that has nothing to do with fastlane.

I still had the ram-bundle enabled in my bundle build phase, you obviously have to remove that when using Hermes. 🤦

@fastlane fastlane locked and limited conversation to collaborators Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants