[fastlane_core] escape xcrun itmstransporter password for special characters #16795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
janpio
approved these changes
Jul 8, 2020
|
Yup yup! I was able to replicate the issue and fix. I spent a stupid amount of hours trying to figure this out 😛 |
joshdholtz
deleted the
joshdholtz-shell-escape-xcrun-itmstransporter-password
branch
This was referenced Jul 9, 2020
fastlane-bot
reviewed
Jul 9, 2020
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.151.2 🚀
|
Tbh I do not fully understand why this works better. Probably some shell interpolating stuff? |
minuscorp
pushed a commit
to minuscorp/fastlane
that referenced
this pull request
Jul 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #16777
Description
ITMS_TRANSPORTER_PASSWORDvariable beforexcrun iTMSTransporter-p @env:ITMS_TRANSPORTER_PASSWORDto telliTMSTransporterto look at the env@envat https://help.apple.com/itc/transporteruserguide/en.lproj/static.html