[deliver] Update fakefs to 1.2.x #16791
Conversation
1.x marked that it's considered stable. New releases also removed Ruby 2.7 warnings which should help with running fastlane on 2.7. https://github.com/fakefs/fakefs/blob/master/CHANGELOG.md fastlane#16342
|
@aried3r I'm working on reimplementing those specs this week and next week 😇 Those got commented out during the great migration of 2.150.X to the new App Store Connect API. I don't plan to keep them like this for long 😛 |
|
Hey @aried3r 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.151.2 🚀
1.x marked that it's considered stable. New releases also removed Ruby 2.7 warnings which should help with running fastlane on 2.7. https://github.com/fakefs/fakefs/blob/master/CHANGELOG.md fastlane#16342
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
Update to a release that is considered stable and fixes some Ruby 2.7 warnings.
Description
1.x marked that it's considered stable. New releases also removed Ruby 2.7 warnings which should help with running fastlane on 2.7.
https://github.com/fakefs/fakefs/blob/master/CHANGELOG.md
#16342
Testing Steps
I did not test the commented out specs here:
https://github.com/fastlane/fastlane/blob/fastlane/2.151.1/deliver/spec/upload_screenshots_spec.rb
Unrelated to this PR, but should these maybe the properly skipped so it's more explicit that there is a file which is not actually run?