Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spaceship] return model (not response) from create #16786

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

joshdholtz
Copy link
Member

Motivation and Context

Slack message from @bolom

Description

Return with .first from the update method (which is used when setting a frame time code)

@joshdholtz joshdholtz changed the title [spaceship] return model (not response) from create) [spaceship] return model (not response) from create Jul 8, 2020
@joshdholtz joshdholtz merged commit cd6bdef into master Jul 8, 2020
@joshdholtz joshdholtz deleted the joshdholtz-app_preview-return-model-from-create branch July 8, 2020 19:26
@fastlane-bot
Copy link

Hey @joshdholtz 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.151.2 🚀

minuscorp pushed a commit to minuscorp/fastlane that referenced this pull request Jul 18, 2020
@fastlane fastlane locked and limited conversation to collaborators Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants