Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] add retry to notarize when request uuid isn't ready #16782

Merged
merged 1 commit into from Jul 7, 2020

Conversation

joshdholtz
Copy link
Member

@joshdholtz joshdholtz commented Jul 7, 2020

Motivation and Context

Fixzes #16710
Fixes #16770
cc: @odrobnik

Description

  • Requesting notarization info sometimes will give error of “Can’t find RequestUUID”
    • The RequestUUID is there (since it was given in a previous response) but seems to maybe be a timing/caching issue
    • These changes pass in an error_callback to prevent an error from being raised so the retry can keep happening

@joshdholtz joshdholtz merged commit 31b45cf into master Jul 7, 2020
@joshdholtz joshdholtz deleted the joshdholtz-notarize-retry-if-no-request-uuid branch July 7, 2020 20:33
Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.151.0 🚀

minuscorp pushed a commit to minuscorp/fastlane that referenced this pull request Jul 18, 2020
@fastlane fastlane locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notarize: handle lag on Apple server
2 participants