[spaceship] Loosen jwt dependency #16778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow newer 2.x versions. The gem follows semantic versioning so this should be fine. https://github.com/jwt/ruby-jwt#development-and-tests
aried3r
force-pushed
the
ar/loosen_jwt_dependency
branch
from
c793ce0
to
b080baa
Compare
joshdholtz
approved these changes
Jul 7, 2020
|
Hey @aried3r 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
fastlane-bot
reviewed
Jul 7, 2020
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.151.0 🚀
minuscorp
pushed a commit
to minuscorp/fastlane
that referenced
this pull request
Jul 18, 2020
Allow newer 2.x versions. The gem follows semantic versioning so this should be fine. https://github.com/jwt/ruby-jwt#development-and-tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
I want to be able to use newer versions of the
jwtgem. Right now, there's no feature that fastlane could use in versions > 2.1.x, but it should also keep us up to date so huge changes and complicated updates don't pile up.Description
Allow newer 2.x versions. The gem follows semantic versioning so this should be fine.
https://github.com/jwt/ruby-jwt#development-and-tests