[spaceship] Update sinatra to 2.x (uses rack 2.x) #16776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sinatra usage in this project is easy enough that it didn't need any changes when updating. While being on the latest release should be reason enough, there is one nice thing implicitly done here (not shown since no `Gemfile.lock` is being committed), is that `rack` is now also at `~> 2.0`, which receives updates and security fixes (although most were backported to 1.6.x). https://github.com/sinatra/sinatra/blob/master/CHANGELOG.md https://github.com/rack/rack/blob/master/CHANGELOG.md Example of a backported CVE fix. https://nvd.nist.gov/vuln/detail/CVE-2019-16782
joshdholtz
approved these changes
Jul 7, 2020
|
Hey @aried3r 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
fastlane-bot
reviewed
Jul 7, 2020
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.151.0 🚀
minuscorp
pushed a commit
to minuscorp/fastlane
that referenced
this pull request
Jul 18, 2020
The sinatra usage in this project is easy enough that it didn't need any changes when updating. While being on the latest release should be reason enough, there is one nice thing implicitly done here (not shown since no `Gemfile.lock` is being committed), is that `rack` is now also at `~> 2.0`, which receives updates and security fixes (although most were backported to 1.6.x). https://github.com/sinatra/sinatra/blob/master/CHANGELOG.md https://github.com/rack/rack/blob/master/CHANGELOG.md Example of a backported CVE fix. https://nvd.nist.gov/vuln/detail/CVE-2019-16782
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
The sinatra usage in this project is easy enough that it didn't need any changes when updating. While being on the latest release should be reason enough, there is one nice thing implicitly done here (not shown since no
Gemfile.lockis being committed), is thatrackis now also at~> 2.0, which receives updates and security fixes (although most were backported to 1.6.x).Description
No real description, but some CHANGELOG.md files to see what changed.
https://github.com/sinatra/sinatra/blob/master/CHANGELOG.md
https://github.com/rack/rack/blob/master/CHANGELOG.md
Example of a backported CVE fix.
https://nvd.nist.gov/vuln/detail/CVE-2019-16782