[deliver] set default ITMSTransporter transport flag to blank #16749 #16774
Conversation
| # server outage, or something they changed without giving a heads-up | ||
| if ENV["DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS"].to_s.length == 0 | ||
| ENV["DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS"] = "-t DAV,Signiant" | ||
| env_deliver_additional_params = ENV["DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS"] |
There was a problem hiding this comment.
Can you add a comment above this with the new issue that this is fixing? 😊 I know that info will come in handy down the road
There was a problem hiding this comment.
Sure, will do within 2 hours
There was a problem hiding this comment.
Done, please take a look ;)
castus
force-pushed
the
set-default-itmstransporter-transport-flag-to-none
branch
from
9049f50
to
977f872
Compare
joshdholtz
changed the title
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.151.0 🚀
…e#16749 (fastlane#16774) * Set default ITMSTransporter transport flag to blank fastlane#16749 * Check upload options ENV if nil or empty Co-authored-by: Josh Holtz <josh@rokkincat.com>
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
It solves issue #16749
Description
According to Apple's Transporter User Guide 2.0 documentation Apple recommends to not specify transport option and let the tool to determine the best transport mode for packages. It is also visible in the comments, in the mentioned issue that setting this parameter to empty string, fix the issue.
Testing Steps
Try to use deliver or pilot to send build to TestFlight without
DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERSENV variable being set.