Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deliver] set type of auto release date to integer #16767

Merged
merged 2 commits into from Jul 7, 2020
Merged

[deliver] set type of auto release date to integer #16767

merged 2 commits into from Jul 7, 2020

Conversation

joshdholtz
Copy link
Member

Motivation and Context

Fixes #16640 (comment)

Description

Fixes issue like 馃憞

upload_metadata.rb:327:in convert_ms_to_iso8601': undefined method /' for "1596146400000":String

myanime
myanime approved these changes Jul 6, 2020
View reviewed changes
Copy link

@myanime myanime left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 馃憤 I spent nearly half a day trying to figure this out ;).
EDIT: Was just thinking about this, maybe it might be a good idea to somehow validate if this Integer is at least 13 numbers long, ie milliseconds. Its pretty easy to make a mistake and put seconds in here. Not for this PR obviously, but maybe something to think about down the line.

@joshdholtz
Copy link
Member Author

@myanime I like that validation actually 馃 I will add it to this PR now 馃槉

@joshdholtz
Copy link
Member Author

@myanime 馃憢 I updated this with a validation to make sure auto_release_date is greater than Time.now.to_i * 1000. This should make sure its in ms and in the future.

@joshdholtz joshdholtz merged commit 12ef145 into master Jul 7, 2020
@joshdholtz joshdholtz deleted the joshdholtz-deliver-auto_release_date_int branch July 7, 2020 15:24
@fastlane-bot
Copy link

Hey @joshdholtz 馃憢

Thank you for your contribution to fastlane and congrats on getting this pull request merged 馃帀
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 馃憤
We'll notify you once we shipped a new release with your changes 馃殌

@joshdholtz joshdholtz mentioned this pull request Jul 7, 2020
Merged
fastlane-bot
fastlane-bot reviewed Jul 7, 2020
View reviewed changes
Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 馃帀 This was released as part of fastlane 2.151.0 馃殌

minuscorp pushed a commit to minuscorp/fastlane that referenced this pull request Jul 18, 2020
@minuscorp
[deliver] set type of auto release date to integer (fastlane#16767)
9a0c6f8 
* [deliver] set type of auto release date to integer

* Add validation to make sure auto_release_date is greater than now in ms
@fastlane fastlane locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fastlane-bot fastlane-bot fastlane-bot left review comments

@myanime myanime myanime approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joshdholtz @fastlane-bot @myanime @googlebot