Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upload_symbols_to_crashlytics] add support for debug flag #16745

Merged
merged 2 commits into from Jul 4, 2020

Conversation

yangsu
Copy link
Contributor

@yangsu yangsu commented Jul 3, 2020

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Make it easier to diagnose problems for upload-symbols, particularly in CI environments. Here's an issue I ran into with our pipeline that turned out to be a network proxy configuration problem.
image

Description

  • Added a debug flag for upload_symbols_to_crashlytics with default: false
  • When debug is enabled, log upload-symbols output by default
  • Added test case that covers the new debug argument and a previously untested path for the platform config value

Testing Steps

I tested this locally and the cryptic message from above turned into this on my local machine
image

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@yangsu
Copy link
Contributor Author

yangsu commented Jul 3, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 3, 2020
@janpio janpio changed the title upload_symbols_to_crashlytics: add support for debug flag [upload_symbols_to_crashlytics] add support for debug flag Jul 4, 2020
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful - thanks!

@janpio janpio merged commit 5734f46 into fastlane:master Jul 4, 2020
@yangsu yangsu deleted the crashlytics_debug_flag branch July 4, 2020 18:12
@fastlane-bot
Copy link

Hey @yangsu 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.151.0 🚀

minuscorp pushed a commit to minuscorp/fastlane that referenced this pull request Jul 18, 2020
@fastlane fastlane locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants