New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[resign] Fix typo in resign.rb #16705
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catch! 🚀
@googlebot I signed it! edit: My company representative just signed an additional doc via e-mail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching this! ❤️
@eduardopelitti Can you sign the CLA when you get a chance? 😊 |
@googlebot I signed it! Just gave it another try @joshdholtz, I was waiting for my company representatives to complete the company form. Hope it works this time. edit: Hmm, I see I now have an Individual CLA instead of a Company CLA. An authorized person from my company already signed the CLA and my email account is included in the contributors group, what else should I do? Also it's the primary account of my Github user (eduardo@underscope.io) My intention is to contribute on behalf of my company (Underscope.io), but since this is a really minor contribution I don't want to add any more overhead to this. So if GoogleBot is ok with the individual CLA, then we could just go ahead and merge it. |
@eduardopelitti Looks like you are good now (the bot just isn't updating this). Thank you!! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Hey @eduardopelitti 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.151.0 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Fixes a typo in the documentation.
Description
Add missing "g" to "provisioning"
Did not test at all.
Testing Steps