Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resign] Fix typo in resign.rb #16705

Merged
merged 1 commit into from Jul 6, 2020
Merged

Conversation

eduardopelitti
Copy link
Contributor

@eduardopelitti eduardopelitti commented Jun 29, 2020

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Fixes a typo in the documentation.

Description

Add missing "g" to "provisioning"

Did not test at all.

Testing Steps

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@janpio janpio changed the title Fix typo in resign.rb [resign] Fix typo in resign.rb Jun 30, 2020
Copy link
Collaborator

@minuscorp minuscorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catch! 🚀

@eduardopelitti
Copy link
Contributor Author

eduardopelitti commented Jul 2, 2020

@googlebot I signed it!

edit: My company representative just signed an additional doc via e-mail.

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this! ❤️

@joshdholtz
Copy link
Member

@eduardopelitti Can you sign the CLA when you get a chance? 😊

@eduardopelitti
Copy link
Contributor Author

eduardopelitti commented Jul 6, 2020

@googlebot I signed it!

Just gave it another try @joshdholtz, I was waiting for my company representatives to complete the company form. Hope it works this time.

edit: Hmm, I see I now have an Individual CLA instead of a Company CLA.

An authorized person from my company already signed the CLA and my email account is included in the contributors group, what else should I do? Also it's the primary account of my Github user (eduardo@underscope.io)

My intention is to contribute on behalf of my company (Underscope.io), but since this is a really minor contribution I don't want to add any more overhead to this. So if GoogleBot is ok with the individual CLA, then we could just go ahead and merge it.

@joshdholtz
Copy link
Member

@eduardopelitti Looks like you are good now (the bot just isn't updating this). Thank you!!

@joshdholtz joshdholtz merged commit 1bbf2d6 into fastlane:master Jul 6, 2020
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 6, 2020
@fastlane-bot
Copy link

Hey @eduardopelitti 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.151.0 🚀

minuscorp pushed a commit to minuscorp/fastlane that referenced this pull request Jul 18, 2020
@fastlane fastlane locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants