-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action] add synchronous option to pod_push #16698
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Edit: scratch that. It seems to have been a transient CI issue. Re-running the pipeline fixed it. |
Hey @iartemiev 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.151.0 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Updating the pod_push action with a recently-added option.
--synchronous assists developers when deploying multiple interdependent pods to Trunk
CocoaPods PR for context: CocoaPods/cocoapods-trunk#147
Description
Added code to append the option when
synchronous: true
is passed as a param to thepod_push
action.Augmented the
available_options
array for the action with the requisite details about the param.Testing Steps
Added a test for this option to pod_push_spec.rb