Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] add synchronous option to pod_push #16698

Merged
merged 2 commits into from
Jul 4, 2020

Conversation

iartemiev
Copy link
Contributor

@iartemiev iartemiev commented Jun 29, 2020

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Updating the pod_push action with a recently-added option.
--synchronous assists developers when deploying multiple interdependent pods to Trunk
CocoaPods PR for context: CocoaPods/cocoapods-trunk#147

Description

Added code to append the option when synchronous: true is passed as a param to the pod_push action.
Augmented the available_options array for the action with the requisite details about the param.

Testing Steps

Added a test for this option to pod_push_spec.rb

@googlebot

This comment has been minimized.

@iartemiev

This comment has been minimized.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@iartemiev
Copy link
Contributor Author

iartemiev commented Jun 29, 2020

The failing CCI job is returning the following error:

/usr/local/Homebrew/Library/Homebrew/brew.rb:10:in `<main>': Homebrew must be run under Ruby 2.6! You're running 2.3.3. (RuntimeError)

Seems to be a CI-related issue...

Edit: scratch that. It seems to have been a transient CI issue. Re-running the pipeline fixed it.

@janpio janpio merged commit 7a32523 into fastlane:master Jul 4, 2020
@fastlane-bot
Copy link

Hey @iartemiev 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.151.0 🚀

minuscorp pushed a commit to minuscorp/fastlane that referenced this pull request Jul 18, 2020
@fastlane fastlane locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants