[spaceship] Remove multi_xml dependency #16697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an optional dependency for `faraday_middleware` when parsing XML responses. As far as I can tell, and from what is being tested with fixtures, that used to be the case but is not any longer using the App Store Connect API. There is a custom plist middleware, but that one is in fastlane itself and does not make use of `multi_xml`. I believe it's used by `#provisioning_profiles_via_xcode_api`. https://github.com/fastlane/fastlane/blob/2.150.0.rc4/spaceship/lib/spaceship/portal/portal_client.rb#L653-L674 https://github.com/fastlane/fastlane/blob/2.150.0.rc4/spaceship/lib/spaceship/helper/plist_middleware.rb
joshdholtz
approved these changes
Jul 6, 2020
|
Hey @aried3r 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
This was referenced Jul 6, 2020
fastlane-bot
reviewed
Jul 7, 2020
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.151.0 🚀
minuscorp
pushed a commit
to minuscorp/fastlane
that referenced
this pull request
Jul 18, 2020
This was an optional dependency for `faraday_middleware` when parsing XML responses. As far as I can tell, and from what is being tested with fixtures, that used to be the case but is not any longer using the App Store Connect API. There is a custom plist middleware, but that one is in fastlane itself and does not make use of `multi_xml`. I believe it's used by `#provisioning_profiles_via_xcode_api`. https://github.com/fastlane/fastlane/blob/2.150.0.rc4/spaceship/lib/spaceship/portal/portal_client.rb#L653-L674 https://github.com/fastlane/fastlane/blob/2.150.0.rc4/spaceship/lib/spaceship/helper/plist_middleware.rb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
I believe
multi_xmlis not needed. This PR is what #16664 should have been. Thanks to the feedback by @janpio I took another look.Description
This was an optional dependency for
faraday_middlewarewhen parsing XML responses. As far as I can tell, and from what is being tested with fixtures, that used to be the case but is not any longer, using the App Store Connect API.There is a custom plist middleware, but that one is in fastlane itself and does not make use of
multi_xml. I believe it's used by#provisioning_profiles_via_xcode_api.https://github.com/fastlane/fastlane/blob/2.150.0.rc4/spaceship/lib/spaceship/portal/portal_client.rb#L653-L674
https://github.com/fastlane/fastlane/blob/2.150.0.rc4/spaceship/lib/spaceship/helper/plist_middleware.rb
The client was introduced in #14888.
Testing Steps
Ran the tests, worked. :)