New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fastlane.swift] Add formatter to Fastlane.swift #16693
[Fastlane.swift] Add formatter to Fastlane.swift #16693
Conversation
Awesome! 😍 Do you think it would make sense to add SwiftLint as well? |
I just wanted a formatter, not a linter, if that difference makes sense. I just want to make sure that the code is following a set of common format rules and correct them if they fail (as Rubocop do) Swiftlint goes further with enabling and disabling rules and so on, I think it'll be too much for the project itself. What do you think? |
Of course, I was not questioning the choice of the formatter, formatters and linters do serve different purposes and both are valid in a project. I was only raising the possibility of adding SwiftLint on top of SwiftFormat, which could lint things that a formatter does not handle such as function and file length, nesting, etc. |
The case is, the people will get the project already formatted into their Fastlane.swift, we do not force any rules because we do not embed the formatter into the project, just into the code that is being pushed. It is then user choice to make their own code changes, linting, etc. Any code that breaks is actually out of the organization, more of the user digging into the codebase 😛 EDIT: We let the user decide to lint the project or event add more format rules. We're just making babysteps to make the codebase more readable in different iterations 😄 |
Makes sense @minuscorp, thanks for the clarification 👌 |
My plans are to improve the Swift current codebase as much as possible in further PRs, but I have a wait list 😪 it will come 😈 |
@joshdholtz 👀 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is 🔥 Never crossed my mind to format this lol. Thanks for adding this in 😍
Hey @minuscorp 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.151.0 🚀
* Add linter to Fastlane.swift * Formatting
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
I've seen that the Swift codebase doesn't follow any lint rules nor common syntax rules, so the first step is to integrate Swiftformat to ensure that every API or external change gets linted properly into the codebase. This not makes conflict to propose changes or cleanup code as proposed by another members.
Description
Testing Steps