[match] Add s3_object_prefix option to match's S3Storage.
#16682
Conversation
This option is used to add a prefix to all objects managed by match. It does not automatically add a trailing `/` character to specify a directory.
|
Not sure how best to address the failing build The step beforehand prints out: If anyone has any thoughts on the best path forward let me know. |
janpio
changed the title
s3_object_prefix option to match's S3Storage.s3_object_prefix option to match's S3Storage.
|
I usually just restart the tests - this error message does not make any sense. I fear it is some random machine on Circle CI that just lies to us for some reason. IF you have an idea how to fix it, pleeeeease let me know. |
|
Uh hey @googlebot, how about the CLA label thing!? |
atreat
force-pushed
the
feature/match-s3-prefix
branch
from
75094ba
to
c6b3fe4
Compare
Will prepend this value to all target_paths of uploaded/deleted files Will strip this value from the object_key when downloading files so the path in the working directory is maintained.
atreat
force-pushed
the
feature/match-s3-prefix
branch
from
c6b3fe4
to
a115e4c
Compare
|
Hey @atreat 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.151.0 🚀
…#16682) * Adds `s3_object_prefix option to match. This option is used to add a prefix to all objects managed by match. It does not automatically add a trailing `/` character to specify a directory. * Updates match runner to pass `s3_object_prefix` option to Storage * Updates S3Storage to handle `s3_object_prefix` option Will prepend this value to all target_paths of uploaded/deleted files Will strip this value from the object_key when downloading files so the path in the working directory is maintained. * Update regex when stripping s3_object_prefix from object_path * Reverts changes to Match runner spec
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
Wanted to use the Match S3 storage option but realized that it would take over the bucket I had planned to use. With a prefix, I'd be able to keep android/ios codesign assets in the same bucket but partitioned off correctly.
Description
This adds the
s3_object_prefix(MATCH_S3_OBJECT_PREFIXenvvar) as an available option. This can be used to help partition match in an existing bucket.Testing Steps
I've added RSpec examples for the areas that were updated. Also updated what seemed to be an odd stub mechanism in the runner spec as I did not expect tests to fail because this new optional option was not present.
I also switched over to use this updated option locally and was able to import my existing certificates/profiles into the expected s3 structure.