Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Installation] Change the brew cask install fastlane in any output to brew install fastlane #16670

Merged
merged 1 commit into from Jul 6, 2020
Merged

[Installation] Change the brew cask install fastlane in any output to brew install fastlane #16670

merged 1 commit into from Jul 6, 2020

Conversation

SConaway
Copy link
Contributor

Fastlane was migrated to homebrew-core by Homebrew/homebrew-core/47709 in December 2019, so I think that the generated README.md / output should reflect that

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

Testing Steps

…l fastlane`

Fastlane was migrated to homebrew-core by Homebrew/homebrew-core/47709 in December 2019, so I think that the generated README.md / output should reflect that
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@SConaway
Copy link
Contributor Author

SConaway commented Jun 25, 2020

@googlebot I already had signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@janpio janpio requested a review from joshdholtz June 28, 2020 08:11
@janpio janpio changed the title Change the brew cask install fastlane in any output to brew install fastlane [Installation] Change the brew cask install fastlane in any output to brew install fastlane Jun 28, 2020
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesssssss... thanks for making this change!

@joshdholtz joshdholtz merged commit 5d30622 into fastlane:master Jul 6, 2020
@fastlane-bot
Copy link

Hey @SConaway 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.151.0 🚀

minuscorp pushed a commit to minuscorp/fastlane that referenced this pull request Jul 18, 2020
…l fastlane` (fastlane#16670)

Fastlane was migrated to homebrew-core by Homebrew/homebrew-core/47709 in December 2019, so I think that the generated README.md / output should reflect that
@fastlane fastlane locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants