[match] prompt for keychain password to set partition list for certificates to disable xcode prompt for password on sign #16448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdholtz
force-pushed
the
joshdholtz-match-prompt-keychain-password
branch
from
7936d2a
to
7a6d5f6
Compare
joshdholtz
changed the title
joshdholtz
force-pushed
the
joshdholtz-match-prompt-keychain-password
branch
from
7a6d5f6
to
44a52d7
Compare
…icates to disable xcode prompt for password on sign
joshdholtz
force-pushed
the
joshdholtz-match-prompt-keychain-password
branch
from
44a52d7
to
0935b99
Compare
snatchev
requested changes
May 11, 2020
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #14196
Entering the keychain password used for certificate signing (usually login) required storing the keychain password in an environment variable or passing it in via options which was pretty insure. This will allow for a prompt of the password and store the password for the keychain in the keychain to use later.
Description
Also fixed broken match tests that were using
allowinstead ofexpectfor someOpen3commands. TheOpen3command weren’t getting mocked properly so the inside was never getting executed which means not all of the things were getting tested properly 🤷♂️Testing Steps
fastlane_keychain_<keychain_name>entry