[frameit] Automatically determine platform from fastfile #16428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frameit refactoring and decoupling from the deliver module New Device class which contains all necessary device information: id, device name, priority, resolutions, screen pixel density, default color and platform Added "use_platform" parameter which can be specified in Framefile.json, fastfile or passed via CLI parameters; default is iOS for backward compatibility Added new "android" and "ios" commands for frameit Updated frames_generator to include Android devices and exclude some deprecated devices Updated frames_generator's image magick commands to remove shadows and correctly process Android devices (specifically Samsung Galaxy S9 whose screen contains shadows representing round edges) Updated frameit docs with Android support Created unit tests for the new Device class Fixed force_device_type option which didn't work before, also added support to Framefile.json Added iPhone 8 support Added new option :use_legacy_iphone7 to prefer iPhone 7 over iPhone 8 Code style fixes according to rubocop
Searching algorithm compares filename with the device's name without "Apple" for backward compatibility
Co-Authored-By: Jan Piotrowski <piotrowski+github@gmail.com>
…wered perceived complexity of config_parser.validate_key)
# Conflicts: # frameit/lib/frameit/screenshot.rb
…in frameit/lib/frameit/screenshot.rb
…Facebook devices Updated device_spec to count with newer iPhone 11 Pro Added new devices: Google Pixel 4, Google Pixel 4 XL, Samsung Galaxy Note 10, Samsung Galaxy Note 10+, Samsung Galaxy S10, Samsung Galaxy S10+, Xiaomi Mi Mix Alpha, iPhone 11, iPhone 11 Pro, iPhone 11 Pro Max, iPad 10.2, iPad Air 2019, iPad Mini 2019
Fixed name for iPad Pro 12.9 3rd gen. Fixed device name sanitization in offsets.rb Created legacy options for iPhone XR, XS and XS Max
…m since it already supports Android; replaced by team_name
…m since it already supports Android; replaced by team_name
… for detecting device frames from fastfile's general defined platform unless configured otherwise.
|
@googlebot I consent. |
joshdholtz
approved these changes
May 12, 2020
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔑
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
In my previous PR #15087 I added the support for Android to frameit. A part of the mechanism for detecting the platform whose frames should be added to screenshots is new "use_platform" configuration and new commands. Currently frameit determines the platform as follows (sorted according to priority):
If the user has a fastfile with the frameit lane, it is still necessary to provide the platform configuration via one of the described options, otherwise frameit falls back to "IOS" for backward compatibility.
Description
This PR changes this behavior: if fastfile is used and no other configuration provided, the platform is determined based on fastfile's default platform configuration. If fastfile is not used, IOS still remains the default platform.
I tested the PR with these files where several possible scenarios are used.
Testing Steps
Steps are described in the root of the folder whose link is provided above.