-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spaceship] Add to_json for ConnectAPI models #16422
Conversation
Hi @tbodt thanks for the PR! More than happy to test it, do you have some easy testing steps so I can review it and move things forward? |
The test you added @tbodt (Thanks for that!) doesn't seem to be to happy:
|
It passed on my machine. Looks like it only works on ruby 2.6. |
357cf17
to
6b2f161
Compare
Tests pass now :) |
76fce98
to
d46d890
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me! Thanks for the contribution 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
I wanted to write a script that dumps out the list of beta testers as JSON, but the ConnectAPI models didn't have to_json implemented, so I implemented it.
Description
Added a to_json method to ConnectAPI models that returns its attributes in JSON.
Testing Steps
bundle exec rspec spaceship/spec/connect_api/model_spec.rb