[action] set_pod_key: remove shellescape of params

[arnauddorgans]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

I use cocoapods-keys to store API keys but using set_pod_key action automatically escapes the provided parameters.
So each time I provide an API key that contains escapable characters, the API key becomes malformed.

Description

Remove shellescape

Testing Steps

Before:

set_pod_key(key: "PublicKey", value: "XXXX|XXXX", project: "Y")
set_pod_key(key: "ApiKey", value: "XX/nXX==-XX", project: "Y")

After:

set_pod_key(key: "PublicKey", value: "XXXX|XXXX", project: "Y")
set_pod_key(key: "ApiKey", value: "XX/nXX==-XX", project: "Y")

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[arnauddorgans]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[janpio]

Are you sure the current behavior is not just a bug that should be fixed? (I am missing the context what this is usually used for)

[arnauddorgans]

@janpio You are right, there is no point to shellescape parameters, event if we directly call the action from terminal we have to escape our values first otherwise the command will fail.

Test:

I did update the PR with the shellescape deletion

[joshdholtz]

This makes sense to me! The shellescape was definitely not needed since it was already wrapped in quotes 🤷‍♂️ Thanks for fixing! ❤

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀