Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fastlane] drop Ruby 2.0, 2.1, 2.2 and 2.3 from gemspec #16408

Merged
merged 6 commits into from
May 4, 2020
Merged

[fastlane] drop Ruby 2.0, 2.1, 2.2 and 2.3 from gemspec #16408

merged 6 commits into from
May 4, 2020

Conversation

Kaspik
Copy link
Contributor

@Kaspik Kaspik commented Apr 30, 2020

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary - Supported versions are not mentioned anywhere or I didn't find the place.

Motivation and Context

Circle.ci officially stopped supporting Ruby 2.3, we have no test coverage for that and they all are at EOL. There is no reason to keep supporting this without being sure it works via tests.

@Kaspik
Copy link
Contributor Author

Kaspik commented Apr 30, 2020

@joshdholtz Found annoying bug here - Execute tests on Ubuntu was using old Docker image fastlane/ci:0.1.0 with Ruby 2.3.4 instead of 2.4.5...

Let me know if you are okay with this PR for drop, or if not then what do you think. 😊

@joshdholtz
Copy link
Member

@Kaspik Good call on bumping up that docker image version 👌 Looks like Ubuntu tests are failing due to not being able to unzip an IPA in verify_build. You want to look into or want me to look into?

@Kaspik
Copy link
Contributor Author

Kaspik commented Apr 30, 2020

I wonder if it has something to do with the new docker file, otherwise there was no change. It uses system unzip, right? - unzip #{build_path.shellescape} -d #{dir.shellescape} -x '__MACOSX/*' '*.DS_Store'

Honestly I have no idea how to debug this.

@Kaspik Kaspik marked this pull request as ready for review May 1, 2020 23:08
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels May 4, 2020
@joshdholtz
Copy link
Member

@Kaspik I ended up reruning the CircleCI build with an SSH session. I was then able to run the exact unzip command that it was failing in on got this. I’m going to fix by trying to unzip a different incorrectly signed IPA that won’t zip bomb

circleci@2c6ee3bb767d:~/project$ unzip fastlane_core/spec/fixtures/ipas/ContainsWatchApp.ipa -d /tmp/123 -x '__MA
COSX/*' '*.DS_Store'
Archive:  fastlane_core/spec/fixtures/ipas/ContainsWatchApp.ipa
  inflating: /tmp/123/ContainsWatchApp/Payload/Sample.app/Watch/Sample WatchKit App.app/Info.plist  
error: invalid zip file with overlapped components (possible zip bomb)

@joshdholtz
Copy link
Member

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels May 4, 2020
@Kaspik
Copy link
Contributor Author

Kaspik commented May 4, 2020

Wohou, nice! Thanks for this, if all good now, oky to merge from my side. :)

@joshdholtz
Copy link
Member

@Kaspik Looks like its good! I’ll wait for the other tests to pass. Also... TIL about zip bombs lol. I had no idea that was a thing.

@Kaspik
Copy link
Contributor Author

Kaspik commented May 4, 2020

Yeah that’s an interesting one. 😂

@joshdholtz joshdholtz changed the title Drop Ruby 2.0, 2.1, 2.2 and 2.3 from gemspec [fastlane] drop Ruby 2.0, 2.1, 2.2 and 2.3 from gemspec May 4, 2020
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’re good now! Let’s drop these 💪

@joshdholtz joshdholtz merged commit bd2a3f9 into fastlane:master May 4, 2020
@fastlane-bot
Copy link

Hey @Kaspik 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀

aried3r added a commit to aried3r/fastlane that referenced this pull request Jun 4, 2020
Was added in fastlane#10168 because
newer versions of public_suffix didn't support all Ruby versions that
fastlane did. However fastlane now requires Ruby 2.4 or above while
public_suffix supports 2.3 and higher.

fastlane#16408
https://github.com/weppos/publicsuffix-ruby/blob/v4.0.5/CHANGELOG.md#400
joshdholtz pushed a commit that referenced this pull request Jun 5, 2020
Was added in #10168 because
newer versions of public_suffix didn't support all Ruby versions that
fastlane did. However fastlane now requires Ruby 2.4 or above while
public_suffix supports 2.3 and higher.

#16408
https://github.com/weppos/publicsuffix-ruby/blob/v4.0.5/CHANGELOG.md#400
@fastlane fastlane locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants