[Ruby 2.7] Allow Faraday 1.0.0 and Faraday-middleware 1.0.0 with Ruby 2.7 fixes, fix base Ruby 2.3 tests #16399
Conversation
|
From my point of view, we should drop Ruby 2.3 (at least, and of course Ruby 2.0 / 2.1 / 2.2) as it's at the EOL - https://www.ruby-lang.org/en/downloads/branches/. |
Kaspik
changed the title
|
@Kaspik I’ve been thinking about this since I first saw this PR earlier this morning and I think it is time to drop support for 2.3 and lower 😊 I will get that PR going and update docs but this is a great start by dropping those tests 👌 |
|
I didn't really drop them, I just updated the XCode 9 version to Ruby 2.4 - but I think we should/could make default any of the maintained versions instead of EOL version. :) |
|
@Kaspik I know you didn’t drop them but we are going to drop them now 🥳 Those 2.3 tests were actually helpful to find when dependencies started removing support for 2.3 and then we would fix them. I just want to be done with 2.3 completely now so I will create a follow up PR that does that 😇 |
|
I can do that too if you want, anyways main fix here is faraday 1.0.0 for Ruby 2.7 users like me. :) Let me know if you want me to do the test stuff. |
|
@Kaspik Do 2.7 tests pass locally on your machine? 2.7 tests fail on mine. I’m using Ruby 2.7.1. I’m confused on how the tests on CircleCI are passing 🤷♂️ |
|
Pff, check the log... it doesn’t use ruby 2.7 even tho it has the settings :( |
|
@Kaspik Oh noooooo... I guess I’ll be looking into that today 🙃 |
|
@joshdholtz Removed 2.7 tests for now so this is good to go and unblock other PRs. :) |
Kaspik
changed the title
|
Hey @Kaspik 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀
fastlane-bot
added
status: released
and removed
status: included-in-next-release
labels
`danger` 8 supports Ruby 2.4+, like fastlane. The range could of course include `danger` 4 up to 8, but since it's a development dependency, it can be as high as we want it. The reason to update was that it was holding other dependencies back, like `kramdown` or `faraday`. Talking about `faraday`, ironically it had to be locked to less than 1 because of two failing test cases with `faraday` 1.x. Specifically these two: `rspec ./spaceship/spec/portal/enterprise_spec.rb:21` `rspec ./spaceship/spec/portal/portal_client_spec.rb:286` I believe at least one of them is caused by `webmock` in combination with `faraday` and empty arrays as parameters. See also the changelog of `webmock` for version 3.6, which supposedly fixes this. However I haven't tried since this would entail updating `webmock`. The `faraday` dependency was initially loosened in a PR, however to no `Gemfile.lock` being committed, it probably remained largely unnoticed that another dependency (`danger`) was holding it back. https://github.com/danger/danger/blob/v8.0.2/CHANGELOG.md#800 https://github.com/bblimke/webmock/blob/v3.8.3/CHANGELOG.md#360 fastlane#16399 fastlane#8135 Further reading about committing a `Gemfile.lock` file: https://bundler.io/blog/2018/01/17/making-gem-development-a-little-better.html
`danger` 8 supports Ruby 2.4+, like fastlane. The range could of course include `danger` 4 up to 8, but since it's a development dependency, it can be as high as we want it. The reason to update was that it was holding other dependencies back, like `kramdown` or `faraday`. Talking about `faraday`, ironically it had to be locked to less than 1 because of two failing test cases with `faraday` 1.x. Specifically these two: `rspec ./spaceship/spec/portal/enterprise_spec.rb:21` `rspec ./spaceship/spec/portal/portal_client_spec.rb:286` I believe at least one of them is caused by `webmock` in combination with `faraday` and empty arrays as parameters. See also the changelog of `webmock` for version 3.6, which supposedly fixes this. However I haven't tried since this would entail updating `webmock`. The `faraday` dependency was initially loosened in a PR, however to no `Gemfile.lock` being committed, it probably remained largely unnoticed that another dependency (`danger`) was holding it back. https://github.com/danger/danger/blob/v8.0.2/CHANGELOG.md#800 https://github.com/bblimke/webmock/blob/v3.8.3/CHANGELOG.md#360 #16399 #8135 Further reading about committing a `Gemfile.lock` file: https://bundler.io/blog/2018/01/17/making-gem-development-a-little-better.html
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
Xcode 9.4.1, Ruby 2.4#16339Description
Allow Faraday 1.0.0 as first final stable release with Ruby 2.7 fixes included. We still allow older version for users with older Ruby.
Testing
Execute modules load up teststo Ruby 2.4 (should be higher?)