Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[verify_xcode] Add entry with TeamIdentifier=APPLECOMPUTER #16395

Merged
merged 1 commit into from
May 2, 2020

Conversation

teameh
Copy link
Contributor

@teameh teameh commented Apr 28, 2020

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Fixes #16393

Description

See issue for discussion

Testing Steps

  • Download Xcode 11.4 form AppStore.
  • Run fastlane run verify_xcode
  • Should succeed

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@teameh
Copy link
Contributor Author

teameh commented Apr 28, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@teameh
Copy link
Contributor Author

teameh commented Apr 29, 2020

Failing build seems not related to PR. Due to:

/usr/local/Homebrew/Library/Homebrew/brew.rb:10:in `

': Homebrew must be run under Ruby 2.6! You're running 2.3.3. (RuntimeError)

@janpio janpio changed the title Add entry with TeamIdentifier=APPLECOMPUTER to verify_xcode.rb [verify_xcode] Add entry with TeamIdentifier=APPLECOMPUTER May 2, 2020
@janpio janpio merged commit 1c69997 into fastlane:master May 2, 2020
@teameh
Copy link
Contributor Author

teameh commented May 3, 2020

Thanks!

@janpio, did you verify this change youself as well just to be sure?

@janpio
Copy link
Member

janpio commented May 3, 2020

Not really, but as it is an additive change I see no big harm in adding it and seeing what happens. Do you see any risk?

@fastlane-bot
Copy link

Hey @teameh 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@teameh
Copy link
Contributor Author

teameh commented May 3, 2020

Well potentially, me and my colleagues got a binary not signed by apple which would be really bad. You could check your signature and compare the team just to get one more verification.

@janpio
Copy link
Member

janpio commented May 3, 2020

@joshdholtz Can you crosscheck please?

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀

@teameh
Copy link
Contributor Author

teameh commented May 12, 2020

@joshdholtz

@fastlane fastlane locked and limited conversation to collaborators Jul 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcode 11.4 fails verify_xcode verification
4 participants