-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[match] profile name parameter to specify your own provisioning profile name #16386
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks for this PR—it'll solve an issue we're experiencing where we have a "hidden" provisioning profile with the name Match wants to use. Apple won't remove it (we've tried asking). |
Hey @josherbushel 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
The default provisioning profile names can sometimes exceed Apple's allowed length (50 characters). While this works, transferring an app to a different account can cause long profile names to become hidden and thus unable to be deleted. It'd be nice to specify your own custom profile name as you/your company could create your own naming format and/or trim long names to Apple's allowed length.
Description
I added a profile_name parameter to the Match tool. If this is specified, it will use that instead of the default provisioning profile. I added the option in options.rb and modified the generator.rb. I tested it by running fastlane match --profile_name "Your Profile Name". Below is a video of how it works. First command is just the default.
https://www.dropbox.com/s/7m7ordts0d9pczo/FastlaneProfileName.mov?dl=0
Testing Steps
Run fastlane match --profile_name "Your own profile name" in the terminal, or add profile_name parameter in the fastfile.