Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[match] profile name parameter to specify your own provisioning profile name #16386

Merged
merged 3 commits into from
May 2, 2020

Conversation

josherbushel
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

The default provisioning profile names can sometimes exceed Apple's allowed length (50 characters). While this works, transferring an app to a different account can cause long profile names to become hidden and thus unable to be deleted. It'd be nice to specify your own custom profile name as you/your company could create your own naming format and/or trim long names to Apple's allowed length.

Description

I added a profile_name parameter to the Match tool. If this is specified, it will use that instead of the default provisioning profile. I added the option in options.rb and modified the generator.rb. I tested it by running fastlane match --profile_name "Your Profile Name". Below is a video of how it works. First command is just the default.
https://www.dropbox.com/s/7m7ordts0d9pczo/FastlaneProfileName.mov?dl=0

Testing Steps

Run fastlane match --profile_name "Your own profile name" in the terminal, or add profile_name parameter in the fastfile.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@josherbushel
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@craigomac
Copy link

Thanks for this PR—it'll solve an issue we're experiencing where we have a "hidden" provisioning profile with the name Match wants to use. Apple won't remove it (we've tried asking).

@janpio janpio changed the title Added a profile name parameter to the match tool to specify your own provisioning profile name. [match] profile name parameter to specify your own provisioning profile name May 2, 2020
@janpio janpio merged commit 07d2a48 into fastlane:master May 2, 2020
@fastlane-bot
Copy link

Hey @josherbushel 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants