Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snapshot] Add -testPlan option from scan #16350

Merged
merged 1 commit into from
Apr 23, 2020
Merged

[snapshot] Add -testPlan option from scan #16350

merged 1 commit into from
Apr 23, 2020

Conversation

jhandguy
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

To allow more flexibility on which tests to run while capturing screenshots, we need to leverage the -testPlan options that already exists in scan.

Description

This change brings the option -testPlan from scan to snapshot.
The snapshot implementation is extremely similar, if not identical, to the scan implementation.

Testing Steps

I have tested this change in my project and I was able to create a retrying mechanism, that only do so with failing tests.

@jhandguy jhandguy changed the title [snapshot] Add testplan option from scan [snapshot] Add -testPlan option from scan Apr 21, 2020
@janpio janpio merged commit dfe5b9f into fastlane:master Apr 23, 2020
@jhandguy jhandguy deleted the add-snapshot-testplan-option branch April 23, 2020 21:01
@fastlane-bot
Copy link

Hey @jhandguy 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants